* [PATCH] bonding: change igmp_retrans type from s8 to u8
@ 2013-05-29 15:02 nikolay
2013-05-30 8:57 ` Nikolay Aleksandrov
0 siblings, 1 reply; 2+ messages in thread
From: nikolay @ 2013-05-29 15:02 UTC (permalink / raw)
To: netdev; +Cc: davem, andy, fubar
From: Nikolay Aleksandrov <nikolay@redhat.com>
According to the bonding documentation and to the error messages the
resend_igmp should be between 0 and 255, but since the type of the
variable that counts is wrong, this is not the case.
We have igmp_retrans = resend_igmp when the work is started.
Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
---
drivers/net/bonding/bonding.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
index 2baec24..f989e15 100644
--- a/drivers/net/bonding/bonding.h
+++ b/drivers/net/bonding/bonding.h
@@ -225,7 +225,7 @@ struct bonding {
rwlock_t curr_slave_lock;
u8 send_peer_notif;
s8 setup_by_slave;
- s8 igmp_retrans;
+ u8 igmp_retrans;
#ifdef CONFIG_PROC_FS
struct proc_dir_entry *proc_entry;
char proc_file_name[IFNAMSIZ];
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bonding: change igmp_retrans type from s8 to u8
2013-05-29 15:02 [PATCH] bonding: change igmp_retrans type from s8 to u8 nikolay
@ 2013-05-30 8:57 ` Nikolay Aleksandrov
0 siblings, 0 replies; 2+ messages in thread
From: Nikolay Aleksandrov @ 2013-05-30 8:57 UTC (permalink / raw)
To: netdev; +Cc: davem, andy, fubar
On 29/05/13 17:02, nikolay@redhat.com wrote:
> From: Nikolay Aleksandrov <nikolay@redhat.com>
>
> According to the bonding documentation and to the error messages the
> resend_igmp should be between 0 and 255, but since the type of the
> variable that counts is wrong, this is not the case.
> We have igmp_retrans = resend_igmp when the work is started.
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
> ---
Self-NACK, there's another related bug and this is not a full fix.
Dave please don't apply this patch, I'll resend a proper fix.
Nik
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-30 8:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-29 15:02 [PATCH] bonding: change igmp_retrans type from s8 to u8 nikolay
2013-05-30 8:57 ` Nikolay Aleksandrov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).