* [PATCH 6/7] qlcnic: remove redundant D0 power state set
@ 2013-05-30 10:26 Yijing Wang
2013-05-31 13:48 ` Rajesh Borundia
0 siblings, 1 reply; 2+ messages in thread
From: Yijing Wang @ 2013-05-30 10:26 UTC (permalink / raw)
To: Rajesh Borundia, Shahed Shaikh, Jitendra Kalsaria, Sony Chacko
Cc: linux-kernel, linux-driver, netdev, Hanjun Guo, Jiang Liu,
Yijing Wang
Pci_enable_device() will set device power state to D0,
so it's no need to do it again in qlcnic_attach_func().
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index aeb26a8..3585c2c 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -3219,7 +3219,6 @@ static int qlcnic_attach_func(struct pci_dev *pdev)
if (err)
return err;
- pci_set_power_state(pdev, PCI_D0);
pci_set_master(pdev);
pci_restore_state(pdev);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH 6/7] qlcnic: remove redundant D0 power state set
2013-05-30 10:26 [PATCH 6/7] qlcnic: remove redundant D0 power state set Yijing Wang
@ 2013-05-31 13:48 ` Rajesh Borundia
0 siblings, 0 replies; 2+ messages in thread
From: Rajesh Borundia @ 2013-05-31 13:48 UTC (permalink / raw)
To: Yijing Wang, Shahed Shaikh, Jitendra Kalsaria, Sony Chacko
Cc: linux-kernel, Dept-Eng Linux Driver, netdev, Hanjun Guo,
Jiang Liu
>-----Original Message-----
>From: Yijing Wang [mailto:wangyijing@huawei.com]
>Sent: Thursday, May 30, 2013 3:56 PM
>To: Rajesh Borundia; Shahed Shaikh; Jitendra Kalsaria; Sony Chacko
>Cc: linux-kernel; Dept-Eng Linux Driver; netdev; Hanjun Guo; Jiang Liu;
>Yijing Wang
>Subject: [PATCH 6/7] qlcnic: remove redundant D0 power state set
>
>Pci_enable_device() will set device power state to D0,
>so it's no need to do it again in qlcnic_attach_func().
>
>Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>---
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>index aeb26a8..3585c2c 100644
>--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>@@ -3219,7 +3219,6 @@ static int qlcnic_attach_func(struct pci_dev
>*pdev)
> if (err)
> return err;
>
>- pci_set_power_state(pdev, PCI_D0);
> pci_set_master(pdev);
> pci_restore_state(pdev);
>
>--
>1.7.1
>
>
Acked-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-31 13:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-30 10:26 [PATCH 6/7] qlcnic: remove redundant D0 power state set Yijing Wang
2013-05-31 13:48 ` Rajesh Borundia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).