From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [Patch net-next] vxlan: do real refcnt for vn_sock Date: Fri, 31 May 2013 10:55:45 +0800 Message-ID: <1369968945.5304.1.camel@cr0> References: <1369739242-5944-1-git-send-email-amwang@redhat.com> <20130528214142.4e41db6f@nehalam.linuxnetplumber.net> <1369816780.12227.21.camel@cr0> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, "David S. Miller" To: Stephen Hemminger Return-path: Received: from mx1.redhat.com ([209.132.183.28]:29590 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559Ab3EaCzy (ORCPT ); Thu, 30 May 2013 22:55:54 -0400 In-Reply-To: <1369816780.12227.21.camel@cr0> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2013-05-29 at 16:39 +0800, Cong Wang wrote: > On Tue, 2013-05-28 at 21:41 -0700, Stephen Hemminger wrote: > > Why not just fix the requirement to drop rtnl when calling igmp. > > The code comes out cleaner and safer as well. > > Besides you forget to lock the socket before calling _ip_mc_join_group() > (and also the order is very important too), your patch doesn't fix the > problem I met. The full backtrace is below: > Hi, Stephen, Do you think my patch is an easier solution? It at least fixes the crash, while your patch doesn't. :)