From: Eric Dumazet <eric.dumazet@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2] snmp6: fix title of IPSTATS_MIB_CSUMERRORS
Date: Fri, 31 May 2013 08:13:56 -0700 [thread overview]
Message-ID: <1370013236.5109.100.camel@edumazet-glaptop> (raw)
In-Reply-To: <1370007176-30579-1-git-send-email-nicolas.dichtel@6wind.com>
On Fri, 2013-05-31 at 15:32 +0200, Nicolas Dichtel wrote:
> Follow the same convention than other fields, prefix this stat by 'Ip6'.
>
> Spotted-by: Fujie Zhao <fujie.zhao@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
>
> In fact, I wonder if we cannot simply remove this stat for IPv6: there is no
> checksum in IPv6, so it will always be 0 (and in fact, this stats is only
> increased in net/ipv4/ip_input.c).
You could put this line in a comment, so that a future reader knows why
we do have a hole.
next prev parent reply other threads:[~2013-05-31 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 13:29 [PATCH] snmp6: fix title of IPSTATS_MIB_CSUMERRORS Nicolas Dichtel
2013-05-31 13:32 ` [PATCH v2] " Nicolas Dichtel
2013-05-31 15:13 ` Eric Dumazet [this message]
2013-05-31 15:37 ` [PATCH v3] snmp6: remove IPSTATS_MIB_CSUMERRORS Nicolas Dichtel
2013-05-31 17:11 ` Eric Dumazet
2013-05-31 23:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370013236.5109.100.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox