netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: Felix Fietkau <nbd@openwrt.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: Another try at getting pktgen to work with wifi.
Date: Fri, 31 May 2013 19:37:26 +0200	[thread overview]
Message-ID: <1370021846.14117.13.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <51A8DC1C.1040908@candelatech.com> (sfid-20130531_192143_291284_FB196B0A)

On Fri, 2013-05-31 at 10:21 -0700, Ben Greear wrote:

> Before I go work on this, does anyone have any preference over
> whether pktgen packets should obey the QoS or the xmit-queue?

That's the core of the problem is that select_queue has the side effect
of setting skb->priority in mac80211, no? Maybe that side effect needs
to be removed?

Actually that makes it seem like something else should be doing packet
classification, not mac80211 in select_queue()?

Where is skb->priority actually really used in mac80211? I don't see
much?

johannes

  reply	other threads:[~2013-05-31 17:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <51A79E4A.7000609@candelatech.com>
     [not found] ` <51A7B049.9090201@openwrt.org>
     [not found]   ` <51A7BA63.4080403@candelatech.com>
     [not found]     ` <51A857BF.7070008@openwrt.org>
     [not found]       ` <51A857BF.7070008-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2013-05-31 17:21         ` Another try at getting pktgen to work with wifi Ben Greear
2013-05-31 17:37           ` Johannes Berg [this message]
     [not found]             ` <1370021846.14117.13.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2013-05-31 18:00               ` Ben Greear
     [not found]                 ` <51A8E53E.8030101-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-05-31 18:41                   ` Johannes Berg
     [not found]                     ` <1370025698.14117.15.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2013-05-31 18:51                       ` Ben Greear
     [not found]                         ` <51A8F141.5050804-my8/4N5VtI7c+919tysfdA@public.gmane.org>
2013-05-31 19:14                           ` Johannes Berg
     [not found]                             ` <1370027655.14117.17.camel-8Nb76shvtaUJvtFkdXX2HixXY32XiHfO@public.gmane.org>
2013-05-31 19:09                               ` Arend van Spriel
2013-05-31 20:51                           ` Bob Copeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370021846.14117.13.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@openwrt.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).