* [PATCH] netdev: Cocci spatch "ptr_ret.spatch"
@ 2013-06-01 9:55 Thomas Meyer
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Meyer @ 2013-06-01 9:55 UTC (permalink / raw)
To: netdev, linux-kernel
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/drivers/net/ethernet/i825xx/82596.c b/drivers/net/ethernet/i825xx/82596.c
--- a/drivers/net/ethernet/i825xx/82596.c
+++ b/drivers/net/ethernet/i825xx/82596.c
@@ -1527,9 +1527,7 @@ int __init init_module(void)
if (debug >= 0)
i596_debug = debug;
dev_82596 = i82596_probe(-1);
- if (IS_ERR(dev_82596))
- return PTR_ERR(dev_82596);
- return 0;
+ return PTR_RET(dev_82596);
}
void __exit cleanup_module(void)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] netdev: Cocci spatch "ptr_ret.spatch"
@ 2013-06-01 9:59 Thomas Meyer
2013-06-02 2:37 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Meyer @ 2013-06-01 9:59 UTC (permalink / raw)
To: netdev, linux-kernel
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/drivers/net/ethernet/smsc/smc9194.c b/drivers/net/ethernet/smsc/smc9194.c
--- a/drivers/net/ethernet/smsc/smc9194.c
+++ b/drivers/net/ethernet/smsc/smc9194.c
@@ -1571,9 +1571,7 @@ int __init init_module(void)
/* copy the parameters from insmod into the device structure */
devSMC9194 = smc_init(-1);
- if (IS_ERR(devSMC9194))
- return PTR_ERR(devSMC9194);
- return 0;
+ return PTR_RET(devSMC9194);
}
void __exit cleanup_module(void)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] netdev: Cocci spatch "ptr_ret.spatch"
2013-06-01 9:59 Thomas Meyer
@ 2013-06-02 2:37 ` David Miller
2013-06-02 9:02 ` Oliver Hartkopp
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2013-06-02 2:37 UTC (permalink / raw)
To: thomas; +Cc: netdev, linux-kernel
From: Thomas Meyer <thomas@m3y3r.de>
Date: Sat, 01 Jun 2013 11:59:11 +0200
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
This obscure reference to the cocci path you used to find/fix
this problem is insufficient in detail for a commit log message.
You must explain exactly what the problem is, and how you fixed
it, in full sentences. You must make your commit header lin
subject more appropriate as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] netdev: Cocci spatch "ptr_ret.spatch"
2013-06-02 2:37 ` David Miller
@ 2013-06-02 9:02 ` Oliver Hartkopp
0 siblings, 0 replies; 4+ messages in thread
From: Oliver Hartkopp @ 2013-06-02 9:02 UTC (permalink / raw)
To: thomas; +Cc: David Miller, netdev, linux-kernel
Hello Thomas,
additionally to provide a proper log message it is a usual to provide the
coccinelle expression that found the source to be changed.
http://lwn.net/Articles/315686/
E.g. like these
http://marc.info/?l=linux-netdev&m=135081679626023&w=2
http://marc.info/?l=linux-netdev&m=135194048501621&w=2
http://marc.info/?l=linux-netdev&m=135306967411758&w=2
http://marc.info/?l=linux-netdev&m=135304902302198&w=2
Regards,
Oliver
On 02.06.2013 04:37, David Miller wrote:
> From: Thomas Meyer <thomas@m3y3r.de>
> Date: Sat, 01 Jun 2013 11:59:11 +0200
>
>>
>> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
>
> This obscure reference to the cocci path you used to find/fix
> this problem is insufficient in detail for a commit log message.
>
> You must explain exactly what the problem is, and how you fixed
> it, in full sentences. You must make your commit header lin
> subject more appropriate as well.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-02 9:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-01 9:55 [PATCH] netdev: Cocci spatch "ptr_ret.spatch" Thomas Meyer
-- strict thread matches above, loose matches on Subject: below --
2013-06-01 9:59 Thomas Meyer
2013-06-02 2:37 ` David Miller
2013-06-02 9:02 ` Oliver Hartkopp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).