netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jean Sacren <sakiwit@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: do not manually initialize enumerators
Date: Sat, 01 Jun 2013 19:40:03 -0700	[thread overview]
Message-ID: <1370140803.2086.0.camel@joe-AO722> (raw)
In-Reply-To: <1370139797-8912-2-git-send-email-sakiwit@gmail.com>

On Sat, 2013-06-01 at 20:23 -0600, Jean Sacren wrote:
> Clean up unnecessary initialization of enumerators as the compiler takes
> care of that.
[]
> diff --git a/include/linux/net.h b/include/linux/net.h
[]
>  enum sock_shutdown_cmd {
> -	SHUT_RD		= 0,
> -	SHUT_WR		= 1,
> -	SHUT_RDWR	= 2,
> +	SHUT_RD,
> +	SHUT_WR,
> +	SHUT_RDWR,
>  };

The compiler may do the same thing,
but specificity is good.

  reply	other threads:[~2013-06-02  2:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-02  2:23 [PATCH net-next 1/3] xfrm: simplify the exit path of xfrm_output_one() Jean Sacren
2013-06-02  2:23 ` [PATCH net-next 2/3] net: do not manually initialize enumerators Jean Sacren
2013-06-02  2:40   ` Joe Perches [this message]
2013-06-02  3:18     ` Jean Sacren
2013-06-02  3:24       ` Joe Perches
2013-06-02  4:05         ` Jean Sacren
2013-06-04 22:19   ` David Miller
2013-06-02  2:23 ` [PATCH net-next 3/3] Kconfig: remove dangling references to the deleted file Jean Sacren
2013-06-02 10:09   ` Bjørn Mork
2013-06-02 17:28     ` Jean Sacren
2013-06-02 19:24       ` Bjørn Mork
2013-06-04 22:19   ` David Miller
2013-06-04 22:19 ` [PATCH net-next 1/3] xfrm: simplify the exit path of xfrm_output_one() David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370140803.2086.0.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=netdev@vger.kernel.org \
    --cc=sakiwit@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).