* [PATCH net-next] bnx2x: fix a power state test
@ 2013-06-02 9:02 Yuval Mintz
2013-06-03 4:40 ` David Miller
2013-06-04 7:30 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Yuval Mintz @ 2013-06-02 9:02 UTC (permalink / raw)
To: davem, netdev, dan.carpenter
Cc: kernel-janitors, Yuval Mintz, Ariel Elior, Eilon Greenstein
If PCIe supports PM capabilities, bnx2x will always claim eeprom is accessible
as PCI_D0 is zero.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Ariel Elior <ariele@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
Hi Dave,
Please consider applying this to `net-next'.
Thanks,
Yuval
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
index 263950c..04a2ad5 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
@@ -1391,7 +1391,8 @@ static bool bnx2x_is_nvm_accessible(struct bnx2x *bp)
rc = pci_read_config_word(bp->pdev,
bp->pm_cap + PCI_PM_CTRL, &pm);
- if ((rc && !netif_running(dev)) || (!rc && ((pm & PCI_D0) != PCI_D0)))
+ if ((rc && !netif_running(dev)) ||
+ (!rc && ((pm & PCI_PM_CTRL_STATE_MASK) != PCI_D0)))
return false;
return true;
--
1.8.1.227.g44fe835
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] bnx2x: fix a power state test
2013-06-02 9:02 [PATCH net-next] bnx2x: fix a power state test Yuval Mintz
@ 2013-06-03 4:40 ` David Miller
2013-06-04 7:30 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-06-03 4:40 UTC (permalink / raw)
To: yuvalmin; +Cc: netdev, dan.carpenter, kernel-janitors, ariele, eilong
From: "Yuval Mintz" <yuvalmin@broadcom.com>
Date: Sun, 2 Jun 2013 12:02:26 +0300
> If PCIe supports PM capabilities, bnx2x will always claim eeprom is accessible
> as PCI_D0 is zero.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
> Signed-off-by: Ariel Elior <ariele@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] bnx2x: fix a power state test
2013-06-02 9:02 [PATCH net-next] bnx2x: fix a power state test Yuval Mintz
2013-06-03 4:40 ` David Miller
@ 2013-06-04 7:30 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-06-04 7:30 UTC (permalink / raw)
To: Yuval Mintz; +Cc: davem, netdev, kernel-janitors, Ariel Elior, Eilon Greenstein
Thanks, Yuvah.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-04 7:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-02 9:02 [PATCH net-next] bnx2x: fix a power state test Yuval Mintz
2013-06-03 4:40 ` David Miller
2013-06-04 7:30 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).