From: Joe Perches <joe@perches.com>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, Lorenzo Colitti <lorenzo@google.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next 1/2] ping: some cleanup for net/ipv4/ping.c
Date: Sun, 02 Jun 2013 22:59:07 -0700 [thread overview]
Message-ID: <1370239147.2025.0.camel@joe-AO722> (raw)
In-Reply-To: <1370238959-32008-1-git-send-email-amwang@redhat.com>
On Mon, 2013-06-03 at 13:55 +0800, Cong Wang wrote:
> From: Cong Wang <amwang@redhat.com>
[]
> 3. fix "%pI6c" format
[]
> diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
[]
> @@ -318,7 +318,7 @@ int ping_check_bind_addr(struct sock *sk, struct inet_sock *isk,
> return -EINVAL;
>
> pr_debug("ping_check_bind_addr(sk=%p,addr=%pI6c,port=%d)\n",
> - sk, addr->sin6_addr.s6_addr, ntohs(addr->sin6_port));
> + sk, &addr->sin6_addr, ntohs(addr->sin6_port));
why does this matter?
next prev parent reply other threads:[~2013-06-03 5:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 5:55 [Patch net-next 1/2] ping: some cleanup for net/ipv4/ping.c Cong Wang
2013-06-03 5:55 ` [Patch net-next 2/2] ping: use ipv6_iface_scope_id() to get scope id Cong Wang
2013-06-03 7:59 ` Lorenzo Colitti
2013-06-03 8:16 ` Cong Wang
2013-06-03 5:59 ` Joe Perches [this message]
2013-06-03 6:05 ` [Patch net-next 1/2] ping: some cleanup for net/ipv4/ping.c Cong Wang
2013-06-03 7:02 ` Lorenzo Colitti
2013-06-03 7:13 ` Cong Wang
2013-06-03 7:17 ` Lorenzo Colitti
2013-06-03 7:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370239147.2025.0.camel@joe-AO722 \
--to=joe@perches.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).