From: Cong Wang <amwang@redhat.com>
To: Lorenzo Colitti <lorenzo@google.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next 2/2] ping: use ipv6_iface_scope_id() to get scope id
Date: Mon, 03 Jun 2013 16:16:18 +0800 [thread overview]
Message-ID: <1370247378.32297.14.camel@cr0> (raw)
In-Reply-To: <CAKD1Yr1gSjGq-G-G_YLgpUNTy5P8H-OD+rnqLCyW18mVB_bGDg@mail.gmail.com>
On Mon, 2013-06-03 at 16:59 +0900, Lorenzo Colitti wrote:
>
> Good catch, thanks. While you're at it - if np->sndflow is false,
> sin6_flowinfo is not being initialized either. Care to fix that too?
> The other functions do this like this:
>
> sin->sin6_flowinfo = 0;
> if (np->sndflow)
> sin6->sin6_flowinfo = ip6_flowinfo(ip6);
OK, I will add this piece and resend patch 2/2.
next prev parent reply other threads:[~2013-06-03 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 5:55 [Patch net-next 1/2] ping: some cleanup for net/ipv4/ping.c Cong Wang
2013-06-03 5:55 ` [Patch net-next 2/2] ping: use ipv6_iface_scope_id() to get scope id Cong Wang
2013-06-03 7:59 ` Lorenzo Colitti
2013-06-03 8:16 ` Cong Wang [this message]
2013-06-03 5:59 ` [Patch net-next 1/2] ping: some cleanup for net/ipv4/ping.c Joe Perches
2013-06-03 6:05 ` Cong Wang
2013-06-03 7:02 ` Lorenzo Colitti
2013-06-03 7:13 ` Cong Wang
2013-06-03 7:17 ` Lorenzo Colitti
2013-06-03 7:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370247378.32297.14.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).