From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>, Vimalkumar <j.vimal@gmail.com>,
Jiri Pirko <jpirko@redhat.com>
Subject: Re: [PATCH] net_sched: restore "overhead xxx" handling
Date: Mon, 03 Jun 2013 07:08:03 -0700 [thread overview]
Message-ID: <1370268483.24311.145.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130603155621.0cb53b1b@redhat.com>
On Mon, 2013-06-03 at 15:56 +0200, Jesper Dangaard Brouer wrote:
> Would it make sense to add the "overhead" in qdisc_pkt_len_init() or
> qdisc_calculate_pkt_len(), thus updating qdisc_skb_cb(skb)->pkt_len
> instead? (And perhaps also address the per GSO issue).
qdisc_pkt_len_init() is generic (OK for all qdisc)
Each HTB class can have its own computations :
One for the rate, one for the ceil.
It has to be done in HTB.
If only the overhead is needed, its kind of easy for GSO packets, as we
already have gso_segs in hand.
pktlen = qdisc_skb_cb(skb)->pkt_len + gso_segs * overhead;
That will be a net-next patch, since it's not a regression.
prev parent reply other threads:[~2013-06-03 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-02 23:55 [PATCH] net_sched: restore "overhead xxx" handling Eric Dumazet
2013-06-03 5:23 ` David Miller
2013-06-03 13:56 ` Jesper Dangaard Brouer
2013-06-03 14:08 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370268483.24311.145.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=j.vimal@gmail.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox