Re: [PATCH v2 iproute2] get_rate: detect 32bit overflows

[Ben Hutchings <bhutchings@solarflare.com>]

On Mon, 2013-06-03 at 08:51 -0700, Eric Dumazet wrote:
> On Mon, 2013-06-03 at 16:36 +0100, Ben Hutchings wrote:
> 
> > Oops, I read this as being strtol() currently, not strtod().  Currently
> > '1.5gbit' will work, but this change will break that.  So I think you
> > need to keep bps as a double.
> 
> Arg
> 
> > Then here I think the check should be *rate != floor(bps), i.e. accept
> > rounding down of a non-integer number of bytes but any other change is
> > assumed to be overflow.
> 
> Thanks Ben, here is v4 then ;)
> 
> [PATCH v4] get_rate: detect 32bit overflows
> 
> Current rate limit is 34.359.738.360 bit per second, and
> unfortunately 40Gbps links are above it.
> 
> overflows in get_rate() are currently not detected, and some
> users are confused. Let's detect this and complain.
> 
> Note that some qdisc are ready to get extended range, but this will
> need additional attributes and new iproute2
> 
> With help from Ben Hutchings
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
[...]

Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.