* [PATCH net-next] mlx4: use __netdev_pick_tx instead of __skb_tx_hash in mlx4_en_select_queue
@ 2013-06-03 18:07 govindarajulu.v
[not found] ` <51ADC6DE.7060004@mellanox.com>
0 siblings, 1 reply; 2+ messages in thread
From: govindarajulu.v @ 2013-06-03 18:07 UTC (permalink / raw)
To: amirv, davem, netdev; +Cc: eric.dumazet, govindarajulu.v
From: "govindarajulu.v" <govindarajulu90@gmail.com>
mlx4_en_select_queue() uses __skb_tx_hash to select the transmit queue.
XPS settings are ignored by this. Instead, we can use __netdev_pick_tx
to select the transmit queue.
Compile test only.
Signed-off-by: govindarajulu.v <govindarajulu90@gmail.com>
---
drivers/net/ethernet/mellanox/mlx4/en_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
index 4e6877a..7c49238 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
@@ -544,7 +544,7 @@ u16 mlx4_en_select_queue(struct net_device *dev, struct sk_buff *skb)
if (vlan_tx_tag_present(skb))
up = vlan_tx_tag_get(skb) >> VLAN_PRIO_SHIFT;
- return __skb_tx_hash(dev, skb, rings_p_up) + up * rings_p_up;
+ return __netdev_pick_tx(dev, skb) % rings_p_up + up * rings_p_up;
}
static void mlx4_bf_copy(void __iomem *dst, unsigned long *src, unsigned bytecnt)
--
1.8.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] mlx4: use __netdev_pick_tx instead of __skb_tx_hash in mlx4_en_select_queue
[not found] ` <51ADC6DE.7060004@mellanox.com>
@ 2013-06-05 0:30 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-06-05 0:30 UTC (permalink / raw)
To: amirv; +Cc: govindarajulu90, netdev, eric.dumazet
From: Amir Vadai <amirv@mellanox.com>
Date: Tue, 4 Jun 2013 13:52:14 +0300
> On 03/06/2013 21:07, govindarajulu.v wrote:
>> From: "govindarajulu.v" <govindarajulu90@gmail.com>
>>
>> mlx4_en_select_queue() uses __skb_tx_hash to select the transmit queue.
>> XPS settings are ignored by this. Instead, we can use __netdev_pick_tx
>> to select the transmit queue.
>>
>> Compile test only.
>>
>> Signed-off-by: govindarajulu.v <govindarajulu90@gmail.com>
...
> Acked-By: Amir Vadai <amirv@mellanox.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-05 0:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-03 18:07 [PATCH net-next] mlx4: use __netdev_pick_tx instead of __skb_tx_hash in mlx4_en_select_queue govindarajulu.v
[not found] ` <51ADC6DE.7060004@mellanox.com>
2013-06-05 0:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).