* [PATCH 1/2] net: sun4i-emac: Remove redundant platform_set_drvdata()
@ 2013-06-04 10:31 Sachin Kamat
2013-06-04 10:31 ` [PATCH 2/2] net: sun4i-emac: Staticize local symbols Sachin Kamat
2013-06-05 0:40 ` [PATCH 1/2] net: sun4i-emac: Remove redundant platform_set_drvdata() David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-06-04 10:31 UTC (permalink / raw)
To: netdev; +Cc: davem, sachin.kamat, Stefan Roese, Maxime Ripard
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Stefan Roese <sr@denx.de>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
---
drivers/net/ethernet/allwinner/sun4i-emac.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c
index b411344..0049853 100644
--- a/drivers/net/ethernet/allwinner/sun4i-emac.c
+++ b/drivers/net/ethernet/allwinner/sun4i-emac.c
@@ -902,8 +902,6 @@ static int emac_remove(struct platform_device *pdev)
{
struct net_device *ndev = platform_get_drvdata(pdev);
- platform_set_drvdata(pdev, NULL);
-
unregister_netdev(ndev);
free_netdev(ndev);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] net: sun4i-emac: Staticize local symbols
2013-06-04 10:31 [PATCH 1/2] net: sun4i-emac: Remove redundant platform_set_drvdata() Sachin Kamat
@ 2013-06-04 10:31 ` Sachin Kamat
2013-06-05 0:40 ` David Miller
2013-06-05 0:40 ` [PATCH 1/2] net: sun4i-emac: Remove redundant platform_set_drvdata() David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2013-06-04 10:31 UTC (permalink / raw)
To: netdev; +Cc: davem, sachin.kamat, Stefan Roese, Maxime Ripard
Some symbols referenced only in this file are made static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Stefan Roese <sr@denx.de>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
---
drivers/net/ethernet/allwinner/sun4i-emac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c
index 0049853..7d6a5cd 100644
--- a/drivers/net/ethernet/allwinner/sun4i-emac.c
+++ b/drivers/net/ethernet/allwinner/sun4i-emac.c
@@ -258,7 +258,7 @@ static const struct ethtool_ops emac_ethtool_ops = {
.get_link = ethtool_op_get_link,
};
-unsigned int emac_setup(struct net_device *ndev)
+static unsigned int emac_setup(struct net_device *ndev)
{
struct emac_board_info *db = netdev_priv(ndev);
unsigned int reg_val;
@@ -310,7 +310,7 @@ unsigned int emac_setup(struct net_device *ndev)
return 0;
}
-unsigned int emac_powerup(struct net_device *ndev)
+static unsigned int emac_powerup(struct net_device *ndev)
{
struct emac_board_info *db = netdev_priv(ndev);
unsigned int reg_val;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] net: sun4i-emac: Remove redundant platform_set_drvdata()
2013-06-04 10:31 [PATCH 1/2] net: sun4i-emac: Remove redundant platform_set_drvdata() Sachin Kamat
2013-06-04 10:31 ` [PATCH 2/2] net: sun4i-emac: Staticize local symbols Sachin Kamat
@ 2013-06-05 0:40 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2013-06-05 0:40 UTC (permalink / raw)
To: sachin.kamat; +Cc: netdev, sr, maxime.ripard
From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Tue, 4 Jun 2013 16:01:19 +0530
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] net: sun4i-emac: Staticize local symbols
2013-06-04 10:31 ` [PATCH 2/2] net: sun4i-emac: Staticize local symbols Sachin Kamat
@ 2013-06-05 0:40 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2013-06-05 0:40 UTC (permalink / raw)
To: sachin.kamat; +Cc: netdev, sr, maxime.ripard
From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Tue, 4 Jun 2013 16:01:20 +0530
> Some symbols referenced only in this file are made static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-05 0:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-04 10:31 [PATCH 1/2] net: sun4i-emac: Remove redundant platform_set_drvdata() Sachin Kamat
2013-06-04 10:31 ` [PATCH 2/2] net: sun4i-emac: Staticize local symbols Sachin Kamat
2013-06-05 0:40 ` David Miller
2013-06-05 0:40 ` [PATCH 1/2] net: sun4i-emac: Remove redundant platform_set_drvdata() David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).