From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: Bad shaping at low rates, after commit 56b765b79 (htb: improved accuracy at high rates) Date: Tue, 04 Jun 2013 09:02:07 -0700 Message-ID: <1370361727.24311.215.camel@edumazet-glaptop> References: <20130529151330.22c5c89e@redhat.com> <20130604141342.00c8eb9f@redhat.com> <1370359133.24311.208.camel@edumazet-glaptop> <1370361306.24311.214.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , Jiri Benc , David Miller , j.vimal@gmail.com, Michal Soltys , Mike Frysinger , Jussi Kivilinna , Patrick McHardy , Jiri Pirko , Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , Dave Taht , netdev@vger.kernel.org, bloat@lists.bufferbloat.net, Dan Siemon , Jim Gettys , Steven Barth , Felix Fietkau To: Jesper Dangaard Brouer Return-path: Received: from mail-pb0-f43.google.com ([209.85.160.43]:34890 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755798Ab3FDQCK (ORCPT ); Tue, 4 Jun 2013 12:02:10 -0400 Received: by mail-pb0-f43.google.com with SMTP id ma3so445731pbc.30 for ; Tue, 04 Jun 2013 09:02:10 -0700 (PDT) In-Reply-To: <1370361306.24311.214.camel@edumazet-glaptop> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2013-06-04 at 08:55 -0700, Eric Dumazet wrote: > On Tue, 2013-06-04 at 08:18 -0700, Eric Dumazet wrote: > > > I have a good idea of what's going on for htb at low rates, I am testing > > a fix, thanks for the report ! > > > > Yes, we need to convert whole thing to use ns units, instead > of a mix of 64ns and 1ns units. > > Please test the following patch : Oh well, it works only on 64bit arches. I'll send a more complete patch, but thats the idea