netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: davem@davemloft.net, mst@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: sergei.shtylyov@cogentembedded.com, Jason Wang <jasowang@redhat.com>
Subject: [net-next rfc V3 0/9] Multiqueue API for macvtap
Date: Wed,  5 Jun 2013 14:36:23 +0800	[thread overview]
Message-ID: <1370414192-5830-1-git-send-email-jasowang@redhat.com> (raw)

Hi all:

This series implements a v3 of fully tuntap compatiable API which could be used
by userspace to manage multiple macvtap queues. The main parts is to add
TUNSETQUEUE ioctl support for macvtap.

Patch 1 - 5 was some tuntap compatibility and misc cleanups.
Patch 6 removes the linear search in macvtap by reshuffling the macvtaps array
each time a queue is removed. After this, we could store both enabled and
disabled queues in the same array without introducing extra data structure.
Patch 7 let TUNSETIFF can create multiqueue device, nothing but some check
were added.
Patch 8 implement TUNSETQUEUE ioctl
Patch 9 reports IFF_MULTI_QUEUE to userspace to notify the userspace that the
multiqueue API is completed.

Flow caches implememtation were missed in this version, since I am doing
rework on the tuntap flow caches. Have some some stress test with both netperf
and pktgen.

Please review, thanks.

Changes from V2:
- Don't place disabled taps in the array and use a linked like to track all taps
- Remove unnecessary best-effort barriers
- Add ACCESS_ONCE() for vlan->numvtaps to prevent compiler generate unexpected
  codes
- Add a comment to explain that numvtaps is just a hint in macvtap_get_queue()
- blank line fixes

Changes from V1:
- Drop the patch of "return -EBADFD when TUNGETIFF fails" to preserve backward
  compatibility
- Add a small patch of optimizing macvtap_do_read() (see patch 1/8)
- Use different functions to do tap enabling and creating
- Use different functions to do tap disabling and closing
- Remove the emtpy line in patch 6/8
- Add a line in patch 3/8
- Add a comment to explain the checking when doing TUNSETIFF with
  IFF_MULTI_QUEUE
- Add comments to explian the second swapping when moving taps between disabled
  areas and enabled areas.
- Fix the commit log of patch 7/8 ( v1 says the linked list were used which is
  wrong )
- Other minor bug fixes

Jason Wang (9):
  macvtap: fix a possible race between queue selection and changing
    queues
  macvtap: do not add self to waitqueue if doing a nonblock read
  macvlan: switch to use IS_ENABLED()
  macvtap: introduce macvtap_get_vlan()
  macvlan: change the max number of queues to 16
  macvtap: eliminate linear search
  macvtap: allow TUNSETIFF to create multiqueue device
  macvtap: add TUNSETQUEUE ioctl
  macvtap: enable multiqueue flag

 drivers/net/macvtap.c      |  261 ++++++++++++++++++++++++++++++++------------
 include/linux/if_macvlan.h |    8 +-
 2 files changed, 197 insertions(+), 72 deletions(-)

             reply	other threads:[~2013-06-05  6:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-05  6:36 Jason Wang [this message]
2013-06-05  6:36 ` [net-next rfc V3 1/9] macvtap: fix a possible race between queue selection and changing queues Jason Wang
2013-06-05 10:35   ` Michael S. Tsirkin
2013-06-05  6:36 ` [net-next rfc V3 2/9] macvtap: do not add self to waitqueue if doing a nonblock read Jason Wang
2013-06-05 11:07   ` Michael S. Tsirkin
2013-06-05  6:36 ` [net-next rfc V3 3/9] macvlan: switch to use IS_ENABLED() Jason Wang
2013-06-05  6:36 ` [net-next rfc V3 4/9] macvtap: introduce macvtap_get_vlan() Jason Wang
2013-06-05  6:36 ` [net-next rfc V3 5/9] macvlan: change the max number of queues to 16 Jason Wang
2013-06-05  6:36 ` [net-next rfc V3 6/9] macvtap: eliminate linear search Jason Wang
2013-06-05  6:36 ` [net-next rfc V3 7/9] macvtap: allow TUNSETIFF to create multiqueue device Jason Wang
2013-06-05 10:43   ` Michael S. Tsirkin
2013-06-06  3:13     ` Jason Wang
2013-06-06  6:59       ` Michael S. Tsirkin
2013-06-06  7:12         ` Jason Wang
2013-06-06  7:26           ` Michael S. Tsirkin
2013-06-06  7:31             ` Jason Wang
2013-06-05  6:36 ` [net-next rfc V3 8/9] macvtap: add TUNSETQUEUE ioctl Jason Wang
2013-06-05 10:59   ` Michael S. Tsirkin
2013-06-06  3:16     ` Jason Wang
2013-06-06  7:23       ` Michael S. Tsirkin
2013-06-06  7:30         ` Jason Wang
2013-06-05  6:36 ` [net-next rfc V3 9/9] macvtap: enable multiqueue flag Jason Wang
2013-06-05 10:36 ` [net-next rfc V3 0/9] Multiqueue API for macvtap Michael S. Tsirkin
2013-06-06  3:07   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370414192-5830-1-git-send-email-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).