From: Eric Dumazet <eric.dumazet@gmail.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: minor: tcp: use tcp_skb_mss helper in tcp_tso_segment
Date: Thu, 06 Jun 2013 18:20:43 -0700 [thread overview]
Message-ID: <1370568043.24311.406.camel@edumazet-glaptop> (raw)
In-Reply-To: <1370563643-19556-1-git-send-email-dborkman@redhat.com>
On Fri, 2013-06-07 at 02:07 +0200, Daniel Borkmann wrote:
> We have the minimal inline helper tcp_skb_mss to access
> skb_shinfo(skb)->gso_size, so also use it here to get mss.
>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> ---
> net/ipv4/tcp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index b5d4ad9..6a1cf95 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -2905,7 +2905,7 @@ struct sk_buff *tcp_tso_segment(struct sk_buff *skb,
> oldlen = (u16)~skb->len;
> __skb_pull(skb, thlen);
>
> - mss = skb_shinfo(skb)->gso_size;
> + mss = tcp_skb_mss(skb);
Conceptually, this is part of the GRO/GSO layer.
It would be nice to move this stuff in net/ipv4/tcp_offload.c
to makes things explicit.
next prev parent reply other threads:[~2013-06-07 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 0:07 [PATCH net-next] net: minor: tcp: use tcp_skb_mss helper in tcp_tso_segment Daniel Borkmann
2013-06-07 1:20 ` Eric Dumazet [this message]
2013-06-07 5:43 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370568043.24311.406.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox