From: Daniel Borkmann <dborkman@redhat.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: [PATCH net-next 1/2] net: minor: tcp: use tcp_skb_mss helper in tcp_tso_segment
Date: Fri, 7 Jun 2013 17:11:45 +0200 [thread overview]
Message-ID: <1370617906-4849-1-git-send-email-dborkman@redhat.com> (raw)
We have the minimal inline helper tcp_skb_mss to access
skb_shinfo(skb)->gso_size, so also use it here to get mss.
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
---
net/ipv4/tcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index b5d4ad9..6a1cf95 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2905,7 +2905,7 @@ struct sk_buff *tcp_tso_segment(struct sk_buff *skb,
oldlen = (u16)~skb->len;
__skb_pull(skb, thlen);
- mss = skb_shinfo(skb)->gso_size;
+ mss = tcp_skb_mss(skb);
if (unlikely(skb->len <= mss))
goto out;
@@ -3071,7 +3071,7 @@ found:
flush |= *(u32 *)((u8 *)th + i) ^
*(u32 *)((u8 *)th2 + i);
- mss = skb_shinfo(p)->gso_size;
+ mss = tcp_skb_mss(p);
flush |= (len - 1) >= mss;
flush |= (ntohl(th2->seq) + skb_gro_len(p)) ^ ntohl(th->seq);
--
1.7.11.7
next reply other threads:[~2013-06-07 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 15:11 Daniel Borkmann [this message]
2013-06-07 15:11 ` [PATCH net-next 2/2] net: tcp: move GRO/GSO functions to tcp_offload Daniel Borkmann
2013-06-07 15:39 ` Eric Dumazet
2013-06-07 21:39 ` David Miller
2013-06-07 21:39 ` [PATCH net-next 1/2] net: minor: tcp: use tcp_skb_mss helper in tcp_tso_segment David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370617906-4849-1-git-send-email-dborkman@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).