From: Eric Dumazet <eric.dumazet@gmail.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: tcp: move GRO/GSO functions to tcp_offload
Date: Fri, 07 Jun 2013 08:39:11 -0700 [thread overview]
Message-ID: <1370619551.24311.426.camel@edumazet-glaptop> (raw)
In-Reply-To: <1370617906-4849-2-git-send-email-dborkman@redhat.com>
On Fri, 2013-06-07 at 17:11 +0200, Daniel Borkmann wrote:
> Would be good to make things explicit and move those functions to
> a new file called tcp_offload.c, thus make this similar to tcpv6_offload.c.
> While moving all related functions into tcp_offload.c, we can also
> make some of them static, since they are only used there. Also, add
> an explicit registration function.
>
> Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> ---
> I'll also follow-up with a udp_offload.c very soon after we agreed on this one.
LGTM, thanks !
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2013-06-07 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 15:11 [PATCH net-next 1/2] net: minor: tcp: use tcp_skb_mss helper in tcp_tso_segment Daniel Borkmann
2013-06-07 15:11 ` [PATCH net-next 2/2] net: tcp: move GRO/GSO functions to tcp_offload Daniel Borkmann
2013-06-07 15:39 ` Eric Dumazet [this message]
2013-06-07 21:39 ` David Miller
2013-06-07 21:39 ` [PATCH net-next 1/2] net: minor: tcp: use tcp_skb_mss helper in tcp_tso_segment David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370619551.24311.426.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox