netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: David Stevens <dlstevens@us.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, netdev-owner@vger.kernel.org,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [Patch net-next v3 1/3] igmp: fix return value of some functions
Date: Sat, 08 Jun 2013 18:56:43 +0800	[thread overview]
Message-ID: <1370689003.868.3.camel@cr0> (raw)
In-Reply-To: <OFF0DFA533.AF670FB8-ON85257B82.006E0B5C-85257B82.006F58EF@us.ibm.com>

On Thu, 2013-06-06 at 16:16 -0400, David Stevens wrote:
> > From: Cong Wang <amwang@redhat.com>
> 
> > 
> > There are some places casting the return value to void, actually
> > they can respect the return value.
> 
>         This changes the user-visible errno returns, adding new,
> undocumented errno returns for a POSIX-defined API.
> 

Good point! I will convert the such return value to documented ones, for
example, EINVAL.

Thanks!

  reply	other threads:[~2013-06-08 10:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-06  2:20 [Patch net-next v3 1/3] igmp: fix return value of some functions Cong Wang
2013-06-06  2:20 ` [Patch net-next v3 2/3] ipv6,mcast: " Cong Wang
2013-06-06  2:20 ` [Patch net-next v3 3/3] igmp: convert RTNL lock to a spinlock Cong Wang
2013-06-06  2:40   ` Eric Dumazet
2013-06-06  2:50     ` Cong Wang
2013-06-06 20:16 ` [Patch net-next v3 1/3] igmp: fix return value of some functions David Stevens
2013-06-08 10:56   ` Cong Wang [this message]
2013-06-09  2:12   ` David Stevens
2013-06-10  3:07     ` Cong Wang
2013-06-10  3:09       ` Cong Wang
2013-06-10 13:00       ` David Stevens
2013-06-13  8:44         ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370689003.868.3.camel@cr0 \
    --to=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dlstevens@us.ibm.com \
    --cc=netdev-owner@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).