From: Eric Dumazet <eric.dumazet@gmail.com>
To: Neal Cardwell <ncardwell@google.com>
Cc: Yuchung Cheng <ycheng@google.com>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Nandita Dukkipati <nanditad@google.com>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] tcp: properly send new data in fast recovery in first RTT
Date: Tue, 11 Jun 2013 20:57:55 -0700 [thread overview]
Message-ID: <1371009475.3252.53.camel@edumazet-glaptop> (raw)
In-Reply-To: <CADVnQymM_fasoZ6s=Si=gccQ=wvmdt+0jryWovTxLeZw8e95WA@mail.gmail.com>
On Tue, 2013-06-11 at 19:56 -0400, Neal Cardwell wrote:
> On Tue, Jun 11, 2013 at 6:35 PM, Yuchung Cheng <ycheng@google.com> wrote:
> > Linux sends new unset data during disorder and recovery state if all
> > (suspected) lost packets have been retransmitted ( RFC5681, section
> > 3.2 step 1 & 2, RFC3517 section 4, NexSeg() Rule 2). One requirement
> > is to keep the receive window about twice the estimated sender's
> > congestion window (tcp_rcv_space_adjust()), assuming the fast
> > retransmits repair the losses in the next round trip.
> >
> > But currently it's not the case on the first round trip in either
> > normal or Fast Open connection, beucase the initial receive window
> > is identical to (expected) sender's initial congestion window. The
> > fix is to double it.
> >
> > Signed-off-by: Yuchung Cheng <ycheng@google.com>
>
> Acked-by: Neal Cardwell <ncardwell@google.com>
Yes, this is indeed a very nice catch, thanks Yuchung !
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2013-06-12 3:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 22:35 [PATCH net-next] tcp: properly send new data in fast recovery in first RTT Yuchung Cheng
2013-06-11 23:56 ` Neal Cardwell
2013-06-12 3:57 ` Eric Dumazet [this message]
2013-06-13 9:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371009475.3252.53.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=nanditad@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox