[PATCH] net: ethernet: stmicro: stmmac: Fix compile error when STMMAC_XMIT_DEBUG used

[PATCH] net: ethernet: stmicro: stmmac: Fix compile error when STMMAC_XMIT_DEBUG used

[dinguyen]

From: Dinh Nguyen <dinguyen@altera.com>

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function:
stmmac_xmit drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1902:74:
error: expected ) before __func__

Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
CC: David S. Miller <davem@davemloft.net>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 618446a..ee919ca 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1899,7 +1899,7 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev)
 
 #ifdef STMMAC_XMIT_DEBUG
 	if (netif_msg_pktdata(priv)) {
-		pr_info("%s: curr %d dirty=%d entry=%d, first=%p, nfrags=%d"
+		pr_info("%s: curr %d dirty=%d entry=%d, first=%p, nfrags=%d",
 			__func__, (priv->cur_tx % txsize),
 			(priv->dirty_tx % txsize), entry, first, nfrags);
 		if (priv->extend_desc)
-- 
1.7.9.5

Re: [PATCH] net: ethernet: stmicro: stmmac: Fix compile error when STMMAC_XMIT_DEBUG used

[David Miller]

From: <dinguyen@altera.com>
Date: Wed, 12 Jun 2013 11:05:03 -0500

> From: Dinh Nguyen <dinguyen@altera.com>
> 
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function:
> stmmac_xmit drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1902:74:
> error: expected ) before __func__
> 
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> CC: David S. Miller <davem@davemloft.net>

Applied, but this debugging mechanism is completely unacceptable.

We have a dynamic, run time, way to do stuff like this without
peppering up a driver with gross ifdefs.

This driver must be converted over to use "netif_msg_*()" et al.
to guard message logging of different types of events.

Re: [PATCH] net: ethernet: stmicro: stmmac: Fix compile error when STMMAC_XMIT_DEBUG used

[Giuseppe CAVALLARO]

Hello David
On 6/13/2013 10:31 AM, David Miller wrote:
> From: <dinguyen@altera.com>
> Date: Wed, 12 Jun 2013 11:05:03 -0500
>
>> From: Dinh Nguyen <dinguyen@altera.com>
>>
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function:
>> stmmac_xmit drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1902:74:
>> error: expected ) before __func__
>>
>> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
>> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> CC: David S. Miller <davem@davemloft.net>
>
> Applied, but this debugging mechanism is completely unacceptable.

I agree with you, I do not like it too

this debug code is quite old and fixed to the initial driver version.
I had used it to the initial debug so I must rework it (also because
debug has to be guarantee w/o errors and w/o ifdef proliferation)

I'll prepare a patch asap.

Peppe

>
> We have a dynamic, run time, way to do stuff like this without
> peppering up a driver with gross ifdefs.
>
> This driver must be converted over to use "netif_msg_*()" et al.
> to guard message logging of different types of events.
>
>