From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Dean Nelson <dnelson@redhat.com>
Cc: David Miller <davem@davemloft.net>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
netdev@vger.kernel.org, Bruce Allan <bruce.w.allan@intel.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH net-next v2] e1000e: restore call to pci_clear_master()
Date: Wed, 12 Jun 2013 12:48:53 -0700 [thread overview]
Message-ID: <1371066533.2133.41.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20130612194408.8680.66934.email-sent-by-dnelson@teal>
[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]
On Wed, 2013-06-12 at 15:44 -0400, Dean Nelson wrote:
> In attempting to resolve a minor merge conflict, commit
> e5f2ef7ab4690d2e8faa
> (Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net)
> accidently
> dropped a call to pci_clear_master() that was intended to remain in
> place.
>
> Commit 4e0855dff094b0d56d6b (e1000e: fix pci-device enable-counter
> balance)
> replaced a call to pci_disable_device() by one to pci_clear_master().
> And then
> commit 66148babe728f3e00e13 (e1000e: fix runtime power management
> transitions)
> deleted a number of lines starting two lines following that call.
>
> This patch restores the call to pci_clear_master() in
> __e1000_shutdown().
>
> v2: added summary lines (enclosed in parens) following commit IDs
>
> Signed-off-by: Dean Nelson <dnelson@redhat.com>
> ---
> Both stable 3.8.y and 3.9.y appear to have the call to
> pci_clear_master() in
> __e1000_shutdown() as desired. I'm not sure how they avoided the
> conflict.
>
> drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++
> 1 file changed, 2 insertions(+)
Thanks Dean, I will add this to my e1000e queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-06-12 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 19:44 [PATCH net-next v2] e1000e: restore call to pci_clear_master() Dean Nelson
2013-06-12 19:48 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371066533.2133.41.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=dnelson@redhat.com \
--cc=khlebnikov@openvz.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).