From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, Rick Jones <rick.jones2@hp.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>,
Thomas Graf <tgraf@suug.ch>,
David Laight <David.Laight@ACULAB.COM>
Subject: Re: [Patch net-next v2] tcp: introduce a per-route knob for quick ack
Date: Thu, 13 Jun 2013 16:45:57 +0800 [thread overview]
Message-ID: <1371113157.10194.14.camel@cr0> (raw)
In-Reply-To: <1371105776.3252.98.camel@edumazet-glaptop>
On Wed, 2013-06-12 at 23:42 -0700, Eric Dumazet wrote:
> On Thu, 2013-06-13 at 14:24 +0800, Cong Wang wrote:
> > diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> > index ec335fa..f840b92 100644
> > --- a/net/ipv4/tcp_output.c
> > +++ b/net/ipv4/tcp_output.c
> > @@ -160,6 +160,7 @@ static void tcp_event_data_sent(struct tcp_sock *tp,
> > {
> > struct inet_connection_sock *icsk = inet_csk(sk);
> > const u32 now = tcp_time_stamp;
> > + const struct dst_entry *dst = __sk_dst_get(sk);
> >
>
>
> Same here : Are you sure dst cannot be NULL ?
>
No, I missed the check for some reason... Will fix it.
Thanks.
prev parent reply other threads:[~2013-06-13 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 6:24 [Patch net-next v2] tcp: introduce a per-route knob for quick ack Cong Wang
2013-06-13 6:24 ` [Patch iproute2] add quickack option to ip route Cong Wang
2013-06-13 6:42 ` [Patch net-next v2] tcp: introduce a per-route knob for quick ack Eric Dumazet
2013-06-13 8:45 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371113157.10194.14.camel@cr0 \
--to=amwang@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=stephen@networkplumber.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).