From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Bizon Subject: Re: [PATCH net-next] bcm63xx_enet: add support Broadcom BCM6345 Ethernet Date: Thu, 13 Jun 2013 16:24:07 +0200 Message-ID: <1371133447.3032.37.camel@sakura.staff.proxad.net> References: <1371066785-17168-1-git-send-email-florian@openwrt.org> <20130613.014450.1434692343011842828.davem@davemloft.net> <20130613.022524.568792627006552244.davem@davemloft.net> Reply-To: mbizon@freebox.fr Mime-Version: 1.0 Content-Type: text/plain; charset="ANSI_X3.4-1968" Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org, ralf@linux-mips.org, John Crispin , Linux-MIPS , jogo@openwrt.org, Kevin Cernekee To: Florian Fainelli Return-path: In-Reply-To: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: List-Id: netdev.vger.kernel.org On Thu, 2013-06-13 at 10:49 +0100, Florian Fainelli wrote: > We are in the slow process to switch to Device Tree to precisely > eliminate all of this (although not everyone agrees yet on the > details). Hopefully you should not see such things in the future. I don't see how DT help here (hint: it never does) if the driver knows at compile time how registers are shuffled, it can remove the indirection if you use runtime cpu detection or DT, it cannot in fact, this patch already adds another layer of indirection with that "dma_chan_width" thing that the compiler has no way to optimize out, defeating the purpose of single SOC optimization. so we might as well force multi SOC support -- Maxime