From: Gao feng <gaofeng@cn.fujitsu.com>
To: davem@davemloft.net
Cc: ebiederm@xmission.com, netdev@vger.kernel.org,
Gao feng <gaofeng@cn.fujitsu.com>
Subject: [PATCH v2 1/4] neigh: no need to call lookup_neigh_parms in neigh_parms_alloc
Date: Fri, 14 Jun 2013 10:06:44 +0800 [thread overview]
Message-ID: <1371175607-1405-1-git-send-email-gaofeng@cn.fujitsu.com> (raw)
neigh_table.parms always exist and is initialized,kmemdup
can use it to create new neigh_parms, actually lookup_neigh_parms
here will return neigh_table.parms too.
Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
---
net/core/neighbour.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 5c56b21..62d9757 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1429,15 +1429,11 @@ static inline struct neigh_parms *lookup_neigh_parms(struct neigh_table *tbl,
struct neigh_parms *neigh_parms_alloc(struct net_device *dev,
struct neigh_table *tbl)
{
- struct neigh_parms *p, *ref;
+ struct neigh_parms *p;
struct net *net = dev_net(dev);
const struct net_device_ops *ops = dev->netdev_ops;
- ref = lookup_neigh_parms(tbl, net, 0);
- if (!ref)
- return NULL;
-
- p = kmemdup(ref, sizeof(*p), GFP_KERNEL);
+ p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL);
if (p) {
p->tbl = tbl;
atomic_set(&p->refcnt, 1);
--
1.8.1.4
next reply other threads:[~2013-06-14 2:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 2:06 Gao feng [this message]
2013-06-14 2:06 ` [PATCH v2 2/4] neigh: only allow init_net to change the default neigh_parms Gao feng
2013-06-14 2:06 ` [PATCH v2 3/4] neigh: disallow un-init_net to change thresh of neigh Gao feng
2013-06-14 2:06 ` [PATCH v2 4/4] neigh: don't leak default parms to uninitial netns Gao feng
2013-06-20 1:05 ` David Miller
2013-06-20 1:18 ` Gao feng
2013-06-20 1:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371175607-1405-1-git-send-email-gaofeng@cn.fujitsu.com \
--to=gaofeng@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).