netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org, mcgrof@do-not-panic.com,
	kvalo@adurom.com, adrian.chadd@gmail.com
Subject: Re: [PATCH] alx: add a simple AR816x/AR817x device driver
Date: Sat, 15 Jun 2013 20:38:01 +0200	[thread overview]
Message-ID: <1371321481.8319.7.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130613230341.GB16632@electric-eye.fr.zoreil.com>

On Fri, 2013-06-14 at 01:03 +0200, Francois Romieu wrote:
> Johannes Berg <johannes@sipsolutions.net> :
> [...]
> > Yes, I suppose I could, but is it worth it? It's held only for a very
> > short amount of time to get the indirect register access correct. I
> > don't really see any reason to prefer a mutex here?
> 
> Neither a spinlock nor a mutex should be needed but I have to sleep
> before figuring it.

I totally think you're right, I'm just not a big fan of making the
locking difficult to understand :-)

OTOH, I could stick an ASSERT_RTNL() in there and not worry about it.
I'm fairly sure that everything here is under rtnl (work struct I lock
myself, configuration ops will be, and ethtool should be too ...) but
does removing that lock really make the driver better? I'm not really
sure about that.

johannes

  reply	other threads:[~2013-06-15 18:38 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-10 21:26 [PATCH 0/1] alx driver Johannes Berg
2013-06-10 21:26 ` [PATCH 1/1] alx: add a simple AR816x/AR817x device driver Johannes Berg
2013-06-10 21:29 ` [PATCH v2 " Johannes Berg
2013-06-11 22:23   ` Francois Romieu
2013-06-12 18:02     ` Johannes Berg
2013-06-18  1:18   ` Ben Hutchings
2013-06-20 21:40     ` Johannes Berg
2013-06-20 21:58       ` Ben Hutchings
2013-06-20 22:09         ` Johannes Berg
2013-06-21 12:45           ` Ben Hutchings
2013-06-21 20:42             ` Johannes Berg
2013-06-21 21:39               ` Ben Hutchings
2013-06-22 10:17       ` Johannes Stezenbach
2013-06-22 14:21         ` Ben Hutchings
2013-06-25 18:24         ` Johannes Berg
2013-06-12  7:11 ` [PATCH 0/1] alx driver Johannes Stezenbach
2013-06-12 18:00   ` Johannes Berg
2013-06-12 20:33 ` [PATCH] alx: add a simple AR816x/AR817x device driver Johannes Berg
2013-06-12 20:48   ` Stephen Hemminger
2013-06-12 20:51     ` Johannes Berg
2013-06-12 23:02   ` Francois Romieu
2013-06-13  3:46     ` Joe Perches
2013-06-13  6:47       ` Francois Romieu
2013-06-13 21:52     ` Johannes Berg
2013-06-13 23:03       ` Francois Romieu
2013-06-15 18:38         ` Johannes Berg [this message]
2013-06-13 22:24   ` Johannes Stezenbach
2013-06-13 22:29     ` Johannes Berg
2013-06-14  5:53       ` Johannes Stezenbach
2013-06-15 18:26         ` Johannes Berg
2013-06-15 20:15           ` Johannes Berg
2013-06-16  9:49             ` Johannes Stezenbach
2013-06-16 11:17               ` Johannes Berg
2013-06-16 17:48                 ` Johannes Stezenbach
2013-06-16 18:06                   ` Johannes Stezenbach
2013-06-16 18:42                   ` Johannes Stezenbach
2013-06-16 19:41                     ` Johannes Berg
2013-06-16 20:37                       ` Johannes Stezenbach
2013-06-16 12:14               ` Johannes Berg
2013-06-17 20:44 ` [PATCH v4] " Johannes Berg
2013-06-17 23:05   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371321481.8319.7.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=adrian.chadd@gmail.com \
    --cc=kvalo@adurom.com \
    --cc=mcgrof@do-not-panic.com \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).