netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gao feng <gaofeng@cn.fujitsu.com>
To: davem@davemloft.net
Cc: kumaran.4353@gmail.com, netdev@vger.kernel.org,
	Gao feng <gaofeng@cn.fujitsu.com>
Subject: [PATCH] ipv6: don't call addrconf_dst_alloc again when enable lo
Date: Sun, 16 Jun 2013 11:14:30 +0800	[thread overview]
Message-ID: <1371352470-3226-1-git-send-email-gaofeng@cn.fujitsu.com> (raw)

If we disable all of the net interfaces, and enable
un-lo interface before lo interface, we already allocated
the addrconf dst in ipv6_add_addr. So we shouldn't allocate
it again when we enable lo interface.

Otherwise the message below will be triggered.
unregister_netdevice: waiting for sit1 to become free. Usage count = 1

This problem is introduced by commit 25fb6ca4ed9cad72f14f61629b68dc03c0d9713f
"net IPv6 : Fix broken IPv6 routing table after loopback down-up"

Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
---
 net/ipv6/addrconf.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 1bbf744..77b6261 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2655,6 +2655,9 @@ static void init_loopback(struct net_device *dev)
 			if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
 				continue;
 
+			if (sp_ifa->rt)
+				continue;
+
 			sp_rt = addrconf_dst_alloc(idev, &sp_ifa->addr, 0);
 
 			/* Failure cases are ignored */
-- 
1.8.1.4

             reply	other threads:[~2013-06-16  7:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-16  3:14 Gao feng [this message]
2013-06-20  6:05 ` [PATCH] ipv6: don't call addrconf_dst_alloc again when enable lo David Miller
2013-12-31  3:57   ` Hannes Frederic Sowa
2014-01-02  5:48     ` chenweilong
2014-01-02  6:03       ` Hannes Frederic Sowa
2014-01-02  8:13         ` chenweilong
2014-01-02  8:32           ` Hannes Frederic Sowa
2014-01-02  9:08             ` chenweilong
2014-01-02  6:54       ` Hannes Frederic Sowa
2014-01-02  7:58         ` chenweilong
2014-01-02  8:23           ` Hannes Frederic Sowa
2014-01-02  9:33             ` chenweilong
2014-01-03  6:53               ` Hannes Frederic Sowa
2014-01-08  7:50                 ` Gao feng
2014-01-08  8:05                   ` Hannes Frederic Sowa
2014-01-08  8:42                     ` Gao feng
2014-01-08  8:55                       ` Hannes Frederic Sowa
2014-01-17  2:02                         ` chenweilong
2014-01-17  4:09                           ` Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371352470-3226-1-git-send-email-gaofeng@cn.fujitsu.com \
    --to=gaofeng@cn.fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=kumaran.4353@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).