From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dmitry Kravkov <dmitry@broadcom.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Eilon Greenstein <eilong@broadcom.com>
Subject: RE: [PATCH net-next 1/2] bnx2x: add support for ndo_ll_poll
Date: Tue, 18 Jun 2013 04:15:43 -0700 [thread overview]
Message-ID: <1371554143.3252.253.camel@edumazet-glaptop> (raw)
In-Reply-To: <504C9EFCA2D0054393414C9CB605C37F20CBC237@SJEXCHMB06.corp.ad.broadcom.com>
On Tue, 2013-06-18 at 10:45 +0000, Dmitry Kravkov wrote:
> > Ideally, we could keep a counter of enabled LLS sockets, to
> > automatically switch off/on GRO, but in net/core, not in every driver.
>
> Since we have GRO in FW it will be hard to disable/enable it on the fly, probably better to return LL_FLUSH_FAILED when GRO is enabled?
Yes, assuming GRO in FW means latencies ?
(If we receive a frame, FW has to wait a bit for the following frames to
eventually aggregate them)
I thought FW did LRO part on bnx2x, and GRO was the software thing (in
networking core, not in the bnx2x drivre)
next prev parent reply other threads:[~2013-06-18 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 7:42 [PATCH net-next 0/2] bnx2x: add support for low latency rx Dmitry Kravkov
2013-06-18 7:42 ` [PATCH net-next 1/2] bnx2x: add support for ndo_ll_poll Dmitry Kravkov
2013-06-18 8:10 ` Eric Dumazet
2013-06-18 10:45 ` Dmitry Kravkov
2013-06-18 11:15 ` Eric Dumazet [this message]
2013-06-18 12:11 ` Dmitry Kravkov
2013-06-18 7:42 ` [PATCH net-next 2/2] bnx2x: replace mechanism to check for next available packet Dmitry Kravkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371554143.3252.253.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox