From: Joe Perches <joe@perches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: apw@canonical.com, Jacob Keller <jacob.e.keller@intel.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [net] checkpatch: modify logFunction regular expression to allow repeated front tags
Date: Wed, 19 Jun 2013 06:42:03 -0700 [thread overview]
Message-ID: <1371649323.2038.23.camel@joe-AO722> (raw)
In-Reply-To: <1371638323-20999-1-git-send-email-jeffrey.t.kirsher@intel.com>
On Wed, 2013-06-19 at 03:38 -0700, Jeff Kirsher wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> The previous logFunction regular expression allowed names for log functions like
> dev_warn or e_dbg and so forth, but some log functions are of the forms
> similar to e_dev_warn, (adding an additional tag in front of a standard name
> like dev_warn).
Perhaps names like foo_bar_baz_dev_warn are a bit long.
Maybe instead of
+ (?:[a-z0-9]+_)+(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
use
+ (?:[a-z0-9]+_){0,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
next prev parent reply other threads:[~2013-06-19 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 10:38 [net] checkpatch: modify logFunction regular expression to allow repeated front tags Jeff Kirsher
2013-06-19 13:42 ` Joe Perches [this message]
2013-06-19 22:06 ` Keller, Jacob E
2013-06-19 22:49 ` [PATCH v2] checkpatch: Allow longer logging function names Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371649323.2038.23.camel@joe-AO722 \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox