From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH net-next 07/11] sfc: Do not pass non-TCP packets into GRO code
Date: Wed, 19 Jun 2013 15:56:28 -0700 [thread overview]
Message-ID: <1371682588.3252.354.camel@edumazet-glaptop> (raw)
In-Reply-To: <1371680396.1956.114.camel@bwh-desktop.uk.level5networks.com>
On Wed, 2013-06-19 at 23:19 +0100, Ben Hutchings wrote:
> GRO can handle non-TCP packets and pass them up without coalescing,
> but it has to do some extra work to parse the packet which we can
> bypass using the hardware parse result. (Falcon won't mark TCP/IPv6
> packets as TCP, but then it won't validate their checksums either, so
> GRO can't coalesce them.)
Thats not exactly true. GRO can validate the checksums.
next prev parent reply other threads:[~2013-06-19 22:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 22:16 Pull request: sfc-next 2013-06-19 Ben Hutchings
2013-06-19 22:17 ` [PATCH net-next 01/11] sfc: Fix EEH with legacy interrupts Ben Hutchings
2013-06-19 22:18 ` [PATCH net-next 02/11] sfc: Enable RX checksum offload for packets not handled by GRO Ben Hutchings
2013-06-19 22:18 ` [PATCH net-next 03/11] sfc: Increase size of RX SKB header area Ben Hutchings
2013-06-19 22:38 ` Eric Dumazet
2013-06-19 22:18 ` [PATCH net-next 04/11] sfc: Report software timestamping capabilities Ben Hutchings
2013-06-19 22:19 ` [PATCH net-next 05/11] sfc: Enable accelerated RFS on vlans Ben Hutchings
2013-06-19 22:19 ` [PATCH net-next 06/11] sfc: Define and set RX buffer flag for packets parsed as TCP Ben Hutchings
2013-06-19 22:19 ` [PATCH net-next 07/11] sfc: Do not pass non-TCP packets into GRO code Ben Hutchings
2013-06-19 22:56 ` Eric Dumazet [this message]
2013-06-19 23:18 ` Ben Hutchings
2013-06-19 22:20 ` [PATCH net-next 08/11] sfc: Implement RX SKB cache to improve latency Ben Hutchings
2013-06-19 22:20 ` [PATCH net-next 09/11] sfc: Prefetch RX skb header area Ben Hutchings
2013-06-19 22:36 ` Eric Dumazet
2013-06-19 22:39 ` Ben Hutchings
2013-06-19 22:56 ` Eric Dumazet
2013-06-19 23:10 ` Ben Hutchings
2013-06-19 22:21 ` [PATCH net-next 10/11] sfc: Fix IRQ cleanup in case of a probe failure Ben Hutchings
2013-06-19 22:21 ` [PATCH net-next 11/11] sfc: Improve test for IOMMU in use Ben Hutchings
2013-06-19 23:11 ` Pull request: sfc-next 2013-06-19 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371682588.3252.354.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox