From: Eric Dumazet <eric.dumazet@gmail.com>
To: xiaoming gao <gxm.linux.kernel@gmail.com>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org, davem@davemloft.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net bridge: add null pointer check, fix panic
Date: Thu, 20 Jun 2013 01:14:00 -0700 [thread overview]
Message-ID: <1371716040.3252.389.camel@edumazet-glaptop> (raw)
In-Reply-To: <51C2B3A9.5070904@gmail.com>
On Thu, 2013-06-20 at 15:47 +0800, xiaoming gao wrote:
>
> if you remove the test on FF_BRIDGE_PORT, and br_port_get_rcu never returns NULL, the problem is fixed.
> but the codes in mainline is still bugged, am i right??
> by the way, kernel-stable 3.0 and 3.4 tree also have this bug, and is very easily to reproduce.
Commit 00cfec37484761a4 has to be backported anyway, if not already
backported.
I would rather fix things properly, instead of adding defensive code.
next prev parent reply other threads:[~2013-06-20 8:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <51C2710D.2060405@gmail.com>
2013-06-20 3:08 ` [PATCH] net bridge: add null pointer check, fix panic xiaoming gao
2013-06-20 4:55 ` Eric Dumazet
[not found] ` <CAHBR9PJQRw2vuSaG6gpUAGVYsrotNVTjYU_YY6jsA6o0mq4-Jw@mail.gmail.com>
2013-06-20 6:53 ` Fwd: " xiaoming gao
2013-06-20 7:00 ` xiaoming gao
2013-06-20 7:29 ` Eric Dumazet
2013-06-20 7:47 ` xiaoming gao
2013-06-20 8:14 ` Eric Dumazet [this message]
2013-11-11 10:27 ` Alexander Y. Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371716040.3252.389.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=gxm.linux.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox