* [Patch net-next] ipv6: remove a useless pr_info() in addrconf_gre_config()
@ 2013-06-20 8:30 Cong Wang
2013-06-24 1:47 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Cong Wang @ 2013-06-20 8:30 UTC (permalink / raw)
To: netdev; +Cc: Stephen Hemminger, David S. Miller, Cong Wang
From: Cong Wang <amwang@redhat.com>
This is debug info, should at least be pr_debug(), but given
that this code is in upstream for two years, there is no
need to keep this debugging printk any more, so just remove it.
Cc: Stephen Hemminger <stephen@networkplumber.org>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 8044912..90788a1 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2760,8 +2760,6 @@ static void addrconf_gre_config(struct net_device *dev)
struct inet6_dev *idev;
struct in6_addr addr;
- pr_info("%s(%s)\n", __func__, dev->name);
-
ASSERT_RTNL();
if ((idev = ipv6_find_idev(dev)) == NULL) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch net-next] ipv6: remove a useless pr_info() in addrconf_gre_config()
2013-06-20 8:30 [Patch net-next] ipv6: remove a useless pr_info() in addrconf_gre_config() Cong Wang
@ 2013-06-24 1:47 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-06-24 1:47 UTC (permalink / raw)
To: amwang; +Cc: netdev, stephen
From: Cong Wang <amwang@redhat.com>
Date: Thu, 20 Jun 2013 16:30:00 +0800
> From: Cong Wang <amwang@redhat.com>
>
> This is debug info, should at least be pr_debug(), but given
> that this code is in upstream for two years, there is no
> need to keep this debugging printk any more, so just remove it.
>
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-24 1:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-20 8:30 [Patch net-next] ipv6: remove a useless pr_info() in addrconf_gre_config() Cong Wang
2013-06-24 1:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).