From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhao Hongjiang Subject: [PATCH 3/5] net: 8021q: using strlcpy instead of strncpy Date: Thu, 20 Jun 2013 18:49:43 +0800 Message-ID: <1371725385-11540-3-git-send-email-zhaohongjiang@huawei.com> References: <1371725385-11540-1-git-send-email-zhaohongjiang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , , , , , Zhao Hongjiang To: Return-path: Received: from szxga02-in.huawei.com ([119.145.14.65]:45365 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757188Ab3FTKvt (ORCPT ); Thu, 20 Jun 2013 06:51:49 -0400 In-Reply-To: <1371725385-11540-1-git-send-email-zhaohongjiang@huawei.com> Sender: netdev-owner@vger.kernel.org List-ID: for NUL terminated string, need alway set '\0' in the end. Signed-off-by: Zhao Hongjiang --- net/8021q/vlan_dev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 3a8c8fd..b2ef0bf 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -390,7 +390,7 @@ static int vlan_dev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) struct ifreq ifrr; int err = -EOPNOTSUPP; - strncpy(ifrr.ifr_name, real_dev->name, IFNAMSIZ); + strlcpy(ifrr.ifr_name, real_dev->name, sizeof(ifrr.ifr_name)); ifrr.ifr_ifru = ifr->ifr_ifru; switch (cmd) { -- 1.7.1