From: Joe Perches <joe@perches.com>
To: "Christoph Müllner" <christoph.muellner@theobroma-systems.com>
Cc: linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
"David S. Miller" <davem@davemloft.net>,
Fabio Estevam <fabio.estevam@freescale.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: fec: Fix multicast list setup in fec_restart().
Date: Fri, 21 Jun 2013 10:25:08 -0700 [thread overview]
Message-ID: <1371835508.19215.50.camel@joe-AO722> (raw)
In-Reply-To: <61455.62.178.124.14.1371832855.squirrel@mail.theobroma-systems.com>
On Fri, 2013-06-21 at 18:40 +0200, Christoph Müllner wrote:
> Setup the multicast list of the net_device instead of
> clearing it blindly. This restores the multicast groups
> in case of a link down/up event.
>
> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
Theobroma?
food of the gods or does your company just like chocolate?
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
[]
> +static void set_multicast_list(struct net_device *ndev);
[]
> @@ -472,8 +474,7 @@ fec_restart(struct net_device *ndev, int duplex)
> writel(0xffc00000, fep->hwp + FEC_IEVENT);
>
> /* Reset all multicast. */
> - writel(0, fep->hwp + FEC_GRP_HASH_TABLE_HIGH);
> - writel(0, fep->hwp + FEC_GRP_HASH_TABLE_LOW);
> + set_multicast_list(ndev);
maybe dev_set_rx_mode(ndev) ?
next prev parent reply other threads:[~2013-06-21 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 16:40 [PATCH] net: fec: Fix multicast list setup in fec_restart() Christoph Müllner
2013-06-21 17:15 ` Fabio Estevam
2013-06-27 17:14 ` Christoph Müllner
2013-06-27 17:21 ` Fabio Estevam
2013-06-21 17:25 ` Joe Perches [this message]
2013-06-27 19:18 ` [PATCH v2] " Christoph Muellner
2013-07-01 20:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371835508.19215.50.camel@joe-AO722 \
--to=joe@perches.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox