From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 4/6] alx: separate link speed/duplex fields
Date: Fri, 21 Jun 2013 22:43:25 +0200 [thread overview]
Message-ID: <1371847405.8936.1.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1371818249.8771.19.camel@deadeye.wl.decadent.org.uk>
On Fri, 2013-06-21 at 13:37 +0100, Ben Hutchings wrote:
> On Fri, 2013-06-21 at 00:14 +0200, Johannes Berg wrote:
> > As suggested by Ben Hutchings, use separate fields to track
> > current link speed and duplex setting.
> >
> > Reported-by: Ben Hutchings <ben@decadent.org.uk>
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > ---
> > drivers/net/ethernet/atheros/alx/ethtool.c | 35 ++------
> > drivers/net/ethernet/atheros/alx/hw.c | 136 ++++++++++++-----------------
> > drivers/net/ethernet/atheros/alx/hw.h | 24 ++++-
> > drivers/net/ethernet/atheros/alx/main.c | 37 ++++----
> > 4 files changed, 106 insertions(+), 126 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/atheros/alx/ethtool.c b/drivers/net/ethernet/atheros/alx/ethtool.c
> > index 50a91d0..2170b61 100644
> > --- a/drivers/net/ethernet/atheros/alx/ethtool.c
> > +++ b/drivers/net/ethernet/atheros/alx/ethtool.c
> > @@ -58,7 +58,8 @@ static int alx_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
> > SUPPORTED_100baseT_Full |
> > SUPPORTED_Autoneg |
> > SUPPORTED_TP |
> > - SUPPORTED_Pause;
> > + SUPPORTED_Pause |
> > + SUPPORTED_Asym_Pause;
> > if (alx_hw_giga(hw))
> > ecmd->supported |= SUPPORTED_1000baseT_Full;
> >
> [...]
>
> This hunk belongs in patch 6.
Good catch, thanks. I'll resend 4 and 6 (tomorrow or so).
johannes
next prev parent reply other threads:[~2013-06-21 20:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 22:14 [PATCH 0/6] alx: small fixes and cleanups Johannes Berg
2013-06-20 22:14 ` [PATCH 1/6] alx: treat flow control correctly in alx_set_pauseparam() Johannes Berg
2013-06-20 22:14 ` [PATCH 2/6] alx: fix 100mbit/full duplex speed translation Johannes Berg
2013-06-20 22:14 ` [PATCH 3/6] alx: make sizes unsigned Johannes Berg
2013-06-20 22:14 ` [PATCH 4/6] alx: separate link speed/duplex fields Johannes Berg
2013-06-21 12:37 ` Ben Hutchings
2013-06-21 20:43 ` Johannes Berg [this message]
2013-06-20 22:14 ` [PATCH 5/6] alx: fix MAC address alignment problem Johannes Berg
2013-06-21 8:38 ` David Laight
2013-06-21 8:43 ` Johannes Berg
2013-06-20 22:14 ` [PATCH 6/6] alx: fix ethtool support code Johannes Berg
2013-06-21 12:39 ` Ben Hutchings
2013-06-21 20:46 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371847405.8936.1.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ben@decadent.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).