From: Joe Perches <joe@perches.com>
To: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
sony.chacko@qlogic.com, shahed.shaikh@qlogic.com,
Dept_NX_Linux_NIC_Driver@qlogic.com,
Pratik Pujar <pratik.pujar@qlogic.com>
Subject: Re: [PATCH v2 net-next 5/8] qlcnic: Cleanup of structure qlcnic_hardware_context
Date: Sat, 22 Jun 2013 03:53:48 -0700 [thread overview]
Message-ID: <1371898428.3137.5.camel@joe-AO722> (raw)
In-Reply-To: <1371888727-16422-6-git-send-email-jitendra.kalsaria@qlogic.com>
On Sat, 2013-06-22 at 04:12 -0400, Jitendra Kalsaria wrote:
> From: Pratik Pujar <pratik.pujar@qlogic.com>
This isn't really a cleanup.
It's allowing more capabilities.
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
[]
> @@ -449,7 +449,7 @@ struct qlcnic_hardware_context {
> u16 max_pci_func;
>
> u32 capabilities;
> - u32 capabilities2;
> + u32 extra_capability[3];
Also, it looks like it's used as a bitfield.
I suggest instead using an array of ulongs and
something like tg3's use of tg3_flag_set|tg3_flag_clear.
next prev parent reply other threads:[~2013-06-22 10:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-22 8:11 [PATCH v2 net-next 0/8] qlcnic: Driver updates Jitendra Kalsaria
2013-06-22 8:12 ` [PATCH v2 net-next 1/8] qlcnic: Handle qlcnic_alloc_mbx_args() failure Jitendra Kalsaria
2013-06-22 8:12 ` [PATCH v2 net-next 2/8] qlcnic: Secondary unicast MAC address support Jitendra Kalsaria
2013-06-22 8:12 ` [PATCH v2 net-next 3/8] qlcnic: Minimize sleep duration within loopback diagnostic test Jitendra Kalsaria
2013-06-22 8:12 ` [PATCH v2 net-next 4/8] qlcnic: Add support for PEX DMA method to read memory section of adapter dump Jitendra Kalsaria
2013-06-22 8:12 ` [PATCH v2 net-next 5/8] qlcnic: Cleanup of structure qlcnic_hardware_context Jitendra Kalsaria
2013-06-22 10:53 ` Joe Perches [this message]
2013-06-24 18:17 ` Pratik Pujar
2013-06-24 18:19 ` Joe Perches
2013-06-25 5:04 ` Pratik Pujar
2013-06-22 8:12 ` [PATCH v2 net-next 6/8] qlcnic: Add support for 'set driver version' in 83XX Jitendra Kalsaria
2013-06-22 8:12 ` [PATCH v2 net-next 7/8] qlcnic: Add support for 83xx suspend and resume Jitendra Kalsaria
2013-06-22 8:12 ` [PATCH v2 net-next 8/8] qlcnic: Update version to 5.2.44 Jitendra Kalsaria
2013-06-24 1:30 ` [PATCH v2 net-next 0/8] qlcnic: Driver updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371898428.3137.5.camel@joe-AO722 \
--to=joe@perches.com \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=davem@davemloft.net \
--cc=jitendra.kalsaria@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=pratik.pujar@qlogic.com \
--cc=shahed.shaikh@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).