Re: [PATCH v2 net-next 5/8] qlcnic: Cleanup of structure qlcnic_hardware_context

[Joe Perches <joe@perches.com>]

On Mon, 2013-06-24 at 18:17 +0000, Pratik Pujar wrote:
> >-----Original Message-----
> >From: Joe Perches [mailto:joe@perches.com]
> >Sent: 22 June 2013 16:24
> >To: Jitendra Kalsaria
> >Cc: David Miller; netdev; Sony Chacko; Shahed Shaikh; Dept-NX Linux NIC
> >Driver; Pratik Pujar
> >Subject: Re: [PATCH v2 net-next 5/8] qlcnic: Cleanup of structure
> >qlcnic_hardware_context
> >
> >On Sat, 2013-06-22 at 04:12 -0400, Jitendra Kalsaria wrote:
> >> From: Pratik Pujar <pratik.pujar@qlogic.com>
> >
> >This isn't really a cleanup.
> >It's allowing more capabilities.
> 
> The driver was dealing with extra capabilities but separate variables
> were used for these. Now instead of using separate variables, clubbed
> in a single array. 

What was 2 is now 3 no?

> >> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
> >> b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
> >[]
> >> @@ -449,7 +449,7 @@ struct qlcnic_hardware_context {
> >>  	u16 max_pci_func;
> >>
> >>  	u32 capabilities;
> >> -	u32 capabilities2;
> >> +	u32 extra_capability[3];