From: Joe Perches <joe@perches.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 2/7] alx: fix 100mbit/full duplex speed translation
Date: Tue, 25 Jun 2013 12:32:28 -0700 [thread overview]
Message-ID: <1372188748.1245.77.camel@joe-AO722> (raw)
In-Reply-To: <1372185503-24705-3-git-send-email-johannes@sipsolutions.net>
On Tue, 2013-06-25 at 20:38 +0200, Johannes Berg wrote:
> 100mbit full duplex is ADVERTISED_100baseT_Half, not
> ADVERTISED_10baseT_Half.
Correct code, bad commit message.
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> drivers/net/ethernet/atheros/alx/hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/atheros/alx/hw.c b/drivers/net/ethernet/atheros/alx/hw.c
> index 220a16a..dc71cfb 100644
> --- a/drivers/net/ethernet/atheros/alx/hw.c
> +++ b/drivers/net/ethernet/atheros/alx/hw.c
> @@ -1134,7 +1134,7 @@ static inline u32 alx_speed_to_ethadv(int speed)
> case SPEED_100 + DUPLEX_FULL:
> return ADVERTISED_100baseT_Full;
> case SPEED_100 + DUPLEX_HALF:
> - return ADVERTISED_10baseT_Half;
> + return ADVERTISED_100baseT_Half;
> case SPEED_10 + DUPLEX_FULL:
> return ADVERTISED_10baseT_Full;
> case SPEED_10 + DUPLEX_HALF:
next prev parent reply other threads:[~2013-06-25 19:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 18:38 [PATCH v2 0/7] alx: small fixes/cleanups Johannes Berg
2013-06-25 18:38 ` [PATCH v2 1/7] alx: treat flow control correctly in alx_set_pauseparam() Johannes Berg
2013-06-25 18:38 ` [PATCH v2 2/7] alx: fix 100mbit/full duplex speed translation Johannes Berg
2013-06-25 19:32 ` Joe Perches [this message]
2013-06-25 18:38 ` [PATCH v2 3/7] alx: remove NET_CORE Kconfig select Johannes Berg
2013-06-25 18:38 ` [PATCH v2 4/7] alx: make sizes unsigned Johannes Berg
2013-06-25 18:38 ` [PATCH v2 5/7] alx: separate link speed/duplex fields Johannes Berg
2013-06-25 18:38 ` [PATCH v2 6/7] alx: fix MAC address alignment problem Johannes Berg
2013-06-25 18:38 ` [PATCH v2 7/7] alx: fix ethtool support code Johannes Berg
2013-06-25 21:01 ` [PATCH v2 0/7] alx: small fixes/cleanups Johannes Stezenbach
2013-06-29 17:20 ` Johannes Berg
2013-06-29 18:56 ` Johannes Stezenbach
2013-06-26 0:11 ` David Miller
2013-06-29 16:53 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372188748.1245.77.camel@joe-AO722 \
--to=joe@perches.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox