From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH 8/8] pch_gbe: Add MinnowBoard support Date: Tue, 25 Jun 2013 20:11:22 -0700 Message-ID: <1372216282.8177.4.camel@envy.home> References: <6c27e79870ec93f7a8c6692d4bcfebaee589fa6b.1372211451.git.dvhart@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Linux Kernel Mailing List , "H. Peter Anvin" , Peter P Waskiewicz Jr , Andy Shevchenko , danders@circuitco.com, vishal.l.verma@intel.com, "David S. Miller" , netdev To: Bjorn Helgaas Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 2013-06-25 at 20:35 -0600, Bjorn Helgaas wrote: > On Tue, Jun 25, 2013 at 7:53 PM, Darren Hart wrote: > > static DEFINE_PCI_DEVICE_TABLE(pch_gbe_pcidev_id) = { > > {.vendor = PCI_VENDOR_ID_INTEL, > > .device = PCI_DEVICE_ID_INTEL_IOH1_GBE, > > + .subvendor = PCI_VENDOR_ID_CIRCUITCO, > > + .subdevice = PCI_DEVICE_ID_CIRCUITCO_MINNOWBOARD, > > "MINNOWBOARD" seems like a pretty generic name for something that > probably refers only to the gigabit ethernet device in the EG20T. If > you expect to use that same subdevice ID on other devices, I guess we > can add PCI_DEVICE_ID_CIRCUITCO_MINNOWBOARD to pci_ids.h. If it will > only be used for the gigabit ethernet device, we would normally not > add a #define for it and would just use the hex constant here (see the > comment at the top of pci_ids.h). The firmware populates the subsystem vendor and device ID for every device on the PCH with PCI_VENDOR_ID_CIRCUITCO and PCI_DEVICE_ID_CIRCUITCO_MINNOWBOARD, respectively. Currently I have only made changes to pch_gbe to make use of it, but there is the possibility of using this ID elsewhere. I don't currently have plans to do so however. So if it is preferable, I can leave PCI_VENDOR_ID_CIRCUITCO in pci_ids.h and use 0x0001 here for the subsystem device ID. -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel