From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, dvhart@linux.intel.com
Subject: Re: [PATCH v1 2/3] pch_gbe: convert pr_* to netdev_*
Date: Thu, 27 Jun 2013 10:55:06 +0300 [thread overview]
Message-ID: <1372319706.24799.72.camel@smile> (raw)
In-Reply-To: <20130626.134108.1845027788447841042.davem@davemloft.net>
On Wed, 2013-06-26 at 13:41 -0700, David Miller wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Date: Wed, 26 Jun 2013 19:13:36 +0300
>
> > diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c b/drivers/staging/media/lirc/lirc_igorplugusb.c
> > index 28c8b0b..25df7cf 100644
> > --- a/drivers/staging/media/lirc/lirc_igorplugusb.c
> > +++ b/drivers/staging/media/lirc/lirc_igorplugusb.c
> > @@ -408,7 +408,7 @@ static int igorplugusb_remote_probe(struct usb_interface *intf,
> > dprintk(DRIVER_NAME "[%d]: bytes_in_key=%zu maxp=%d\n",
> > devnum, CODE_LENGTH, maxp);
> >
> > - ir = devm_kzalloc(&intf->dev, sizeof(*ir), GFP_KERNEL);
> > + ir = devm_kzalloc(&dev->dev, sizeof(*ir), GFP_KERNEL);
> > if (!ir)
> > return -ENOMEM;
> >
>
> This definitely wasn't supposed to be in this patch series.
>
> Please repost this set with this hunk removed.
Oops, sure.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2013-06-27 7:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 16:13 [PATCH v1 0/3] pch_gbe: few clean ups to the driver Andy Shevchenko
2013-06-26 16:13 ` [PATCH v1 1/3] pch_gbe: remove inline keyword for exported functions Andy Shevchenko
2013-06-26 16:13 ` [PATCH v1 2/3] pch_gbe: convert pr_* to netdev_* Andy Shevchenko
2013-06-26 20:41 ` David Miller
2013-06-27 7:55 ` Andy Shevchenko [this message]
2013-06-27 0:59 ` Joe Perches
2013-06-26 16:13 ` [PATCH v1 3/3] pch_gbe: use managed functions pcim_* and devm_* Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372319706.24799.72.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dvhart@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).