From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Darren Hart <dvhart@linux.intel.com>
Subject: Re: [PATCH v2 2/3] pch_gbe: convert pr_* to netdev_*
Date: Thu, 27 Jun 2013 07:33:59 -0700 [thread overview]
Message-ID: <1372343639.2060.6.camel@joe-AO722> (raw)
In-Reply-To: <1372324994-27793-3-git-send-email-andriy.shevchenko@linux.intel.com>
On Thu, 2013-06-27 at 12:23 +0300, Andy Shevchenko wrote:
> We may use nice macros to prefix our messages with proper device name.
[]
> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
[]
> @@ -573,7 +581,7 @@ u16 pch_gbe_mac_ctrl_miim(struct pch_gbe_hw *hw, u32 addr, u32 dir, u32 reg,
> }
> spin_unlock_irqrestore(&hw->miim_lock, flags);
>
> - pr_debug("PHY %s: reg=%d, data=0x%04X\n",
> + netdev_dbg(adapter->netdev, "PHY %s: reg=%d, data=0x%04X\n",
> dir == PCH_GBE_MIIM_OPER_READ ? "READ" : "WRITE", reg,
> dir == PCH_GBE_MIIM_OPER_READ ? data_out : data);
Hi Andy.
Please make sure to realign the additional
arguments on subsequent lines to the open
parenthesis.
(there are several of these)
next prev parent reply other threads:[~2013-06-27 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 9:23 [PATCH v2 0/3] pch_gbe: few clean ups to the driver Andy Shevchenko
2013-06-27 9:23 ` [PATCH v2 1/3] pch_gbe: remove inline keyword for exported functions Andy Shevchenko
2013-06-27 9:23 ` [PATCH v2 2/3] pch_gbe: convert pr_* to netdev_* Andy Shevchenko
2013-06-27 14:33 ` Joe Perches [this message]
2013-06-27 9:23 ` [PATCH v2 3/3] pch_gbe: use managed functions pcim_* and devm_* Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372343639.2060.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dvhart@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).