From: Johannes Berg <johannes@sipsolutions.net>
To: Johannes Stezenbach <js@sig21.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 8/8] alx: remove WoL support
Date: Sat, 29 Jun 2013 21:40:45 +0200 [thread overview]
Message-ID: <1372534845.17242.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20130629191248.GA10570@sig21.net>
> > - .driver.pm = ALX_PM_OPS,
> > };
>
> Not sure but doesn't that mean the driver breaks after suspend?
> I think you removed too much, not just WOL support but all pm handling.
*sigh*, yes, you're probably right. Probably should stop/restart if the
interface is up. I'll try to poke at it tomorrow.
johannes
next prev parent reply other threads:[~2013-06-29 19:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-29 17:23 [PATCH 0/8] alx fixes/improvements Johannes Berg
2013-06-29 17:23 ` [PATCH 1/8] alx: treat flow control correctly in alx_set_pauseparam() Johannes Berg
2013-06-29 17:23 ` [PATCH 2/8] alx: fix 100mbit/half duplex speed translation Johannes Berg
2013-06-29 17:23 ` [PATCH 3/8] alx: remove NET_CORE Kconfig select Johannes Berg
2013-06-29 17:23 ` [PATCH 4/8] alx: make sizes unsigned Johannes Berg
2013-06-29 17:23 ` [PATCH 5/8] alx: separate link speed/duplex fields Johannes Berg
2013-06-29 17:23 ` [PATCH 6/8] alx: fix MAC address alignment problem Johannes Berg
2013-06-29 17:23 ` [PATCH 7/8] alx: fix ethtool support code Johannes Berg
2013-06-29 17:23 ` [PATCH 8/8] alx: remove WoL support Johannes Berg
2013-06-29 19:12 ` Johannes Stezenbach
2013-06-29 19:40 ` Johannes Berg [this message]
2013-06-30 15:03 ` Johannes Stezenbach
2013-07-01 20:18 ` [PATCH 0/8] alx fixes/improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372534845.17242.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=js@sig21.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).