Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dave Jones <davej@redhat.com>
Cc: netdev@vger.kernel.org, acme@ghostprotocols.net
Subject: Re: appletalk induced soft lockup
Date: Sun, 30 Jun 2013 23:01:30 -0700	[thread overview]
Message-ID: <1372658490.3301.311.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130630234252.GB4325@redhat.com>

On Sun, 2013-06-30 at 19:42 -0400, Dave Jones wrote:
> is atalk even maintained any more ? If not I'll take it out of my testing.
> Arnaldo is listed as its maintainer, but I'm sure he has more interesting things
> to work on these days :)
> 
> 	Dave


Could you try following fix ?

Thanks

diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index ef12839..279a287 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -1638,9 +1638,7 @@ static int atalk_sendmsg(struct kiocb *iocb, struct socket *sock, struct msghdr
 			sk, size, dev->name);
 
 	size += dev->hard_header_len;
-	release_sock(sk);
 	skb = sock_alloc_send_skb(sk, size, (flags & MSG_DONTWAIT), &err);
-	lock_sock(sk);
 	if (!skb)
 		goto out;
 

      parent reply	other threads:[~2013-07-01  6:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-30 23:42 appletalk induced soft lockup Dave Jones
2013-06-30 23:47 ` Dave Jones
2013-07-01  6:01 ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372658490.3301.311.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=davej@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox