From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Baxter Subject: [PATCH net-next v3 1/1] net: fec: Fix RMON registers on imx6 Date: Mon, 1 Jul 2013 14:57:54 +0100 Message-ID: <1372687074-8140-1-git-send-email-jim_baxter@mentor.com> References: Cc: Fabio Estevam , Frank Li , Fugang Duan , Joe Perches , Chris Healy , netdev@vger.kernel.org To: "David S. Miller" Return-path: Received: from relay1.mentorg.com ([192.94.38.131]:64483 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752773Ab3GAN6D (ORCPT ); Mon, 1 Jul 2013 09:58:03 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: commit 38ae92d "fec: Add support for reading RMON registers" causes the imx6Q to crash. This fixes it by only enabling the RMON registers, the registers are already cleared by the MAC being reset. Signed-off-by: Jim Baxter --- Change v1 to v2 Removed per processor change and just set bit 31 to 0. Change v2 to v3 Fixed comment to describe operation correctly. drivers/net/ethernet/freescale/fec_main.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index ed6180e..68834c3 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -605,11 +605,8 @@ fec_restart(struct net_device *ndev, int duplex) ecntl |= (1 << 4); #ifndef CONFIG_M5272 - /* Disable, clear, and enable the MIB */ - writel(1 << 31, fep->hwp + FEC_MIB_CTRLSTAT); - for (i = RMON_T_DROP; i < IEEE_R_OCTETS_OK; i++) - writel(0, fep->hwp + i); - writel(0, fep->hwp + FEC_MIB_CTRLSTAT); + /* Enable the MIB statistic event counters */ + writel(0 << 31, fep->hwp + FEC_MIB_CTRLSTAT); #endif /* And last, enable the transmit and receive processing */ -- 1.7.10.4