From: Steven Rostedt <rostedt@goodmis.org>
To: Jason Baron <jbaron@akamai.com>
Cc: "andi@firstfloor.org" <andi@firstfloor.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH 3/3] udp: make use of static_key_slow_set_true() interface
Date: Mon, 01 Jul 2013 10:28:02 -0400 [thread overview]
Message-ID: <1372688882.22688.1.camel@gandalf.local.home> (raw)
In-Reply-To: <51D10390.4060905@akamai.com>
On Mon, 2013-07-01 at 00:20 -0400, Jason Baron wrote:
>
> >> @@ -1450,7 +1449,7 @@ int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
> >> goto drop;
> >> nf_reset(skb);
> >>
> >> - if (static_key_false(&udp_encap_needed) && up->encap_type) {
> >> + if (static_key_false(&udp_encap_needed.key) && up->encap_type) {
> > I wonder if we should add a static_bool_key_false(), because that added
> > ".key" is a bit confusing.
> >
> > -- Steve
> >
>
> Yeah - that is sort of ugly, but it avoids introducing a new branch API
> call. That said, a 'static_bool_key_false()' would probably be a simple
> wrapper function.
My main concern was to keep true/false separate from counters to
document how this is being used. A simple wrapper would work too.
-- Steve
prev parent reply other threads:[~2013-07-01 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1372457176.git.jbaron@akamai.com>
2013-06-28 22:30 ` [PATCH 3/3] udp: make use of static_key_slow_set_true() interface jbaron
2013-06-29 3:13 ` Steven Rostedt
2013-07-01 4:20 ` Jason Baron
2013-07-01 14:28 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372688882.22688.1.camel@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=jbaron@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).