Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices

[Joe Perches <joe@perches.com>]

On Mon, 2013-07-01 at 11:11 -0700, Roland Dreier wrote:
> On Mon, Jul 1, 2013 at 11:03 AM, Joe Perches <joe@perches.com> wrote:
> > There's some value in block enabling/disabling messages
> > that dynamic_debug doesn't currently offer.
> 
> As far as I can see, the mlx5 stuff ends up being per-file.  Which
> dynamic debug already does offer.

I didn't look too closely.

I do think that all __func__, __LINE__ and pid bits are
useless as it's all duplicated dynamic_debug functionality.

+#define mlx5_core_dbg(dev, format, arg...)                                    \
+do {                                                                          \
+       if (debug_mask & mlx5_core_debug_mask)                                 \
+               pr_debug("%s:%s:%d:(pid %d): " format, (dev)->priv.name,       \
+                        __func__, __LINE__, current->pid, ##arg);             \
+} while (0)
+
+#define mlx5_core_dbg_mask(dev, mask, format, arg...)                         \
+do {                                                                          \
+       if ((mask) & mlx5_core_debug_mask)                                     \
+               pr_debug("%s:%s:%d:(pid %d): " format, (dev)->priv.name,       \
+                        __func__, __LINE__, current->pid, ##arg);             \
+} while (0)

btw:

mlx5_core_dbg should just be

#define mlx5_core_dbg(dev, fmt, ...)				\
	mlx5_core_dbg_mask(dev, debug_mask, fmt, ##__VA_ARGS__)

[]

I think these are the groupings.

+enum {
+       MLX5_MOD_MAIN,
+       MLX5_MOD_CMDIF,
+       MLX5_MOD_EQ,
+       MLX5_MOD_QP,
+       MLX5_MOD_PGALLOC,
+       MLX5_MOD_FW,
+       MLX5_MOD_UAR,
+       MLX5_MOD_ALLOC,
+       MLX5_MOD_DEBUG,
+       MLX5_MOD_HEALTH,
+       MLX5_MOD_MAD,
+       MLX5_MOD_MCG,
+       MLX5_MOD_MR,
+       MLX5_MOD_PD,
+       MLX5_MOD_PORT,
+       MLX5_MOD_SRQ,
+       MLX5_MOD_CQ,
+       MLX5_MOD_CMD_DATA, /* print command payload only */
+       MLX5_CMD_DATA_TIME,
+};
+