From: Fan Du <fan.du@windriver.com>
To: <ebiederm@xmission.com>
Cc: <serge.hallyn@canonical.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>
Subject: [PATCH] net namespace: wrap for_each_net with rtnl_lock
Date: Thu, 4 Jul 2013 14:20:55 +0800 [thread overview]
Message-ID: <1372918855-3815-1-git-send-email-fan.du@windriver.com> (raw)
The read access to net_namespace_list with for_each_net should always
be protected with rtnl_lock agiast any adding/removing operation from
the list.
Signed-off-by: Fan Du <fan.du@windriver.com>
---
net/core/net_namespace.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index f976520..f3808ff 100644
--- a/net/core/net_namespace.c
+++ b/net/core/net_namespace.c
@@ -445,12 +445,14 @@ static int __register_pernet_operations(struct list_head *list,
list_add_tail(&ops->list, list);
if (ops->init || (ops->id && ops->size)) {
+ rtnl_lock();
for_each_net(net) {
error = ops_init(ops, net);
if (error)
goto out_undo;
list_add_tail(&net->exit_list, &net_exit_list);
}
+ rtnl_unlock();
}
return 0;
@@ -468,8 +470,10 @@ static void __unregister_pernet_operations(struct pernet_operations *ops)
LIST_HEAD(net_exit_list);
list_del(&ops->list);
+ rtnl_lock();
for_each_net(net)
list_add_tail(&net->exit_list, &net_exit_list);
+ rtnl_unlock();
ops_exit_list(ops, &net_exit_list);
ops_free_list(ops, &net_exit_list);
}
--
1.7.1
next reply other threads:[~2013-07-04 6:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 6:20 Fan Du [this message]
2013-07-04 7:04 ` [PATCH] net namespace: wrap for_each_net with rtnl_lock Eric W. Biederman
2013-07-04 7:57 ` Fan Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372918855-3815-1-git-send-email-fan.du@windriver.com \
--to=fan.du@windriver.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).