Re: [PATCH V2 1/9] net/mlx5: Mellanox Connect-IB, core driver part 1/3

[Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>]

On Thu, 2013-07-04 at 16:26 +0300, Jack Morgenstein wrote:
> On Wednesday 03 July 2013 23:29, Joe Perches wrote:
> > On Wed, 2013-07-03 at 20:13 +0300, Or Gerlitz wrote:
> > > From: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > 
> > trivial comments:
> > 
> > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > []
> > > +static const char *deliv_status_to_str(u8 status)
> > > +{
> > > +	switch (status) {
> > > +	case MLX5_CMD_DELIVERY_STAT_OK:
> > > +		return "no errors";
> > []
> > > +	default:
> > > +		return "unknown status code\n";
> > > +	}
> > > +}
> > Likely unnecessary newline for default case
> All the cases here have newlines between them, to enhance readability.
> (not just the default). If you feel strongly about this, I'll do the change
> for V3.

Not the vertical spacing, the newline inside the quotes.
ie: "unknown status code\n" should be "unknown status code"


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html