From: Eric Dumazet <eric.dumazet@gmail.com>
To: George Spelvin <linux@horizon.com>
Cc: grundler@parisc-linux.org, netdev@vger.kernel.org
Subject: Re: [RFC] tulip: Support for byte queue limits
Date: Fri, 12 Jul 2013 06:39:45 -0700 [thread overview]
Message-ID: <1373636385.10804.5.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130712132054.16269.qmail@science.horizon.com>
On Fri, 2013-07-12 at 09:20 -0400, George Spelvin wrote:
> The New Hotness of fq_codel wants bql support, but my WAN link is on my
> Old And Busted tulip card, which lacks it.
>
> It's just a few lines, but the important thing is knowing where to
> put them, and I've sort of guessed. In particular, it seems like the
> netdev_sent_queue call could be almost anywhere in tulip_start_xmit and
> I'm not sure if there are reasons to prefer any particular position.
>
> (You may have my S-o-b on copyright grounds, but I'd like to test it
> some more before declaring this patch ready to be merged.)
Seems fine to me.
You might wait before David Miller re-opens net-next for new
submissions, a bit after linux-3.11-rc1 is released, before
sending an official patch.
Thanks
next prev parent reply other threads:[~2013-07-12 13:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 13:20 [RFC] tulip: Support for byte queue limits George Spelvin
2013-07-12 13:39 ` Eric Dumazet [this message]
2013-07-12 16:31 ` Grant Grundler
2013-07-12 18:01 ` George Spelvin
2013-07-12 18:14 ` Grant Grundler
2013-07-15 23:58 ` Ben Hutchings
2013-07-16 1:17 ` Grant Grundler
2013-07-16 1:27 ` Eric Dumazet
2013-07-16 14:37 ` Ben Hutchings
2013-07-16 17:20 ` Grant Grundler
2013-07-17 4:09 ` George Spelvin
2013-07-17 15:42 ` Ben Hutchings
2013-07-31 12:34 ` George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373636385.10804.5.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=grundler@parisc-linux.org \
--cc=linux@horizon.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox